r87771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87770‎ | r87771 | r87772 >
Date:20:53, 9 May 2011
Author:neilk
Status:ok
Tags:
Comment:
followup to r87764; use simpler jquery selector
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -1331,11 +1331,7 @@
13321332 * outside of that library. So we are going to just look for any visible inputs in an error state.
13331333 */
13341334 detailsErrorCount: function() {
1335 - var errorCount =
1336 - $( '#mwe-upwiz-stepdiv-details' ).find( 'input.mwe-error' ).length
1337 - + $( '#mwe-upwiz-stepdiv-details' ).find( 'textarea.mwe-error' ).length
1338 - + $( '#mwe-upwiz-stepdiv-details' ).find( 'input.mwe-validator-error' ).length
1339 - + $( '#mwe-upwiz-stepdiv-details' ).find( 'textarea.mwe-validator-error' ).length;
 1335+ var errorCount = $( '#mwe-upwiz-stepdiv-details' ).find( 'input.mwe-error, textarea.mwe-error, input.mwe-validator-error, textarea.mwe-validator-error' ).length;
13401336 if ( errorCount > 0 ) {
13411337 $( '#mwe-upwiz-details-error-count' ).msg( 'mwe-upwiz-details-error-count', errorCount, this.uploads.length );
13421338 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r87844MFT r87771:r87843awjrichards21:25, 10 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87764count the errors and show them next to the submit button (this helps when the...neilk20:14, 9 May 2011

Status & tagging log