r87770 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87769‎ | r87770 | r87771 >
Date:20:49, 9 May 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: Merge ArticleFeedback to trunk state
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/ArticleFeedback/populateAFStatistics.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/ArticleFeedback/populateAFStatistics.php
@@ -165,9 +165,9 @@
166166 'afshl_avg_overall',
167167 'afshl_avg_ratings'
168168 ),
169 - 'afshl_ts = ' . $cur_ts,
 169+ array( 'afshl_ts' => $cur_ts ),
170170 __METHOD__,
171 - array()
 171+ array( "ORDER BY" => "afshl_avg_overall" )
172172 );
173173 // grab the article feedback special page so we can reuse the data structure building code
174174 // FIXME this logic should not be in the special page class
Index: branches/wmf/1.17wmf1/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -311,8 +311,17 @@
312312 };
313313
314314 /* Load at the bottom of the article */
315 -$( '<div id="mw-articlefeedback"></div>' ).articleFeedback( config ).insertBefore( '#catlinks' );
 315+var $aftDiv = $( '<div id="mw-articlefeedback"></div>' ).articleFeedback( config );
316316
 317+// Put on bottom of article before #catlinks (if it exists)
 318+// Except in Classic, which has #catlinks above the article but inside content-div.
 319+if ( $( '#catlinks' ).length && mw.config.get( 'skin' ) != 'standard' ) {
 320+ $aftDiv.insertBefore( '#catlinks' );
 321+} else {
 322+ // CologneBlue, Nostalgia, ...
 323+ mw.util.$content.append( $aftDiv );
 324+}
 325+
317326 /* Add link so users can navigate to the feedback tool from the toolbox */
318327 var $tbAft = $( '<li id="t-articlefeedback"><a href="#mw-articlefeedback"></a></li>' )
319328 .find( 'a' )

Status & tagging log