r87595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87594‎ | r87595 | r87596 >
Date:23:13, 6 May 2011
Author:reedy
Status:deferred (Comments)
Tags:
Comment:
Xml::hidden() --> Html::hidden()

Xml::hidden() killed
Modified paths:
  • /trunk/extensions/APC/APCCacheMode.php (modified) (history)
  • /trunk/extensions/AdvancedSearch/AdvancedSearch.body.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php (modified) (history)
  • /trunk/extensions/BadImage/BadImage.page.php (modified) (history)
  • /trunk/extensions/CentralAuth/CentralAuthUser.php (modified) (history)
  • /trunk/extensions/CentralAuth/specials/SpecialGlobalUsers.php (modified) (history)
  • /trunk/extensions/ChangeAuthor/ChangeAuthor.body.php (modified) (history)
  • /trunk/extensions/Configure/specials/SpecialViewConfig.php (modified) (history)
  • /trunk/extensions/ConfigureWMF/ConfigureWMF.page.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/RequestAccount_body.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/UserCredentials_body.php (modified) (history)
  • /trunk/extensions/Contributors/Contributors.page.php (modified) (history)
  • /trunk/extensions/Crosswiki/Block/CrosswikiBlock.page.php (modified) (history)
  • /trunk/extensions/DeleteBatch/DeleteBatch.body.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewList.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewNominate.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewReview.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewVote.php (modified) (history)
  • /trunk/extensions/Duplicator/Duplicator.page.php (modified) (history)
  • /trunk/extensions/EnhanceContactForm/EnhanceContactForm.php (modified) (history)
  • /trunk/extensions/Farmer/SpecialFarmer.php (modified) (history)
  • /trunk/extensions/FlagPage/FlagPage.body.php (modified) (history)
  • /trunk/extensions/IndexFunction/SpecialIndex.php (modified) (history)
  • /trunk/extensions/Interwiki/Interwiki_body.php (modified) (history)
  • /trunk/extensions/InterwikiIntegration/SpecialInterwikiWatchlist.php (modified) (history)
  • /trunk/extensions/InterwikiList/InterwikiList_body.php (modified) (history)
  • /trunk/extensions/LanguageSelector/LanguageSelector.php (modified) (history)
  • /trunk/extensions/MassBlank/MassBlank_body.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php (modified) (history)
  • /trunk/extensions/MostRevisors/MostRevisors_body.php (modified) (history)
  • /trunk/extensions/MultiBoilerplate/MultiBoilerplate.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/NewUserMessagesView.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SpecialMergeThread.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/TalkpageView.php (modified) (history)
  • /trunk/extensions/NewestPages/NewestPages.page.php (modified) (history)
  • /trunk/extensions/NssMySQLAuth/SpecialAccountManager.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history)
  • /trunk/extensions/PasswordReset/PasswordReset_body.php (modified) (history)
  • /trunk/extensions/Patroller/Patroller.class.php (modified) (history)
  • /trunk/extensions/Poll/Poll_body.php (modified) (history)
  • /trunk/extensions/PrefSwitch/SpecialPrefSwitch.php (modified) (history)
  • /trunk/extensions/Preview/Preview.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialARC2Admin_body.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialRDFImport_body.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php (modified) (history)
  • /trunk/extensions/RandomInCategory/RandomInCategory.body.php (modified) (history)
  • /trunk/extensions/RefHelper/RefHelper.create.php (modified) (history)
  • /trunk/extensions/RefHelper/RefHelper.search.php (modified) (history)
  • /trunk/extensions/ReplaceText/SpecialReplaceText.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormInputs.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_ParserFunctions.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateCategory.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateClass.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateForm.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_CreateTemplate.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_FormStart.php (modified) (history)
  • /trunk/extensions/SemanticForms/specials/SF_RunQuery.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/compat/Html.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/compat/Html.php (modified) (history)
  • /trunk/extensions/SharedUserRights/SharedUserRights_body.php (modified) (history)
  • /trunk/extensions/SimpleSurvey/SpecialSimpleSurvey.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/SpecialRemoveAvatar.php (modified) (history)
  • /trunk/extensions/SpamDiffTool/SpamDiffTool_body.php (modified) (history)
  • /trunk/extensions/Sudo/SpecialSudo.php (modified) (history)
  • /trunk/extensions/UserMerge/UserMerge_body.php (modified) (history)
  • /trunk/extensions/Vote/Vote.page.php (modified) (history)
  • /trunk/extensions/WatchSubpages/WatchSubpages_body.php (modified) (history)
  • /trunk/phase3/includes/Xml.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r87698Minor revert of comment change from r87595reedy21:45, 8 May 2011
r91212SocialProfile: follow-up to r87595: correct capitalizationashley19:55, 30 June 2011
r91404Reverted r87595 - code within comments doesn't need to be updatedyaron12:57, 4 July 2011
r91406Follow-up to r87595 - restored compatibility for MW < 1.16 in hiddenFieldHTML...yaron14:27, 4 July 2011

Comments

#Comment by Krinkle (talk | contribs)   15:00, 8 May 2011

There's a few changes that may not be intended, I've listed them below. Marking FIXME until Reedy confirms they are OK.


  • trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php
-                  $token = array();
  • trunk/extensions/CentralAuth/CentralAuthUser.php
+        *
+        * @return CentralAuthUser
  • trunk/extensions/CentralAuth/specials/SpecialGlobalUsers.php
-                  $groups = array_keys( $this->getAllGroups() );
  • trunk/extensions/SemanticResultFormats/compat/Html.php
 	          * Convenience function to produce an input element with type=hidden, like
-	          * Xml::hidden.
+	          * Xml::hidden.
	          *
 	          * @param

(Links like http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php?&pathrev=87595&r1=87594&r2=87595 fail due to CodeReview bugs (r1 being linked))


Source:

(Links like <nowiki>http</nowiki>:<nowiki>//svn.wikimedia.org/viewvc/mediawiki/
trunk/extensions/ArticleFeedback/api/ApiArticleFeedback.php?&pathrev=87595&</nowiki>r<nowiki>1=87594
&</nowiki>r<nowiki>2=87595</nowiki> fail due to CodeReview bugs ([[Special:Code/MediaWiki/1|r1]] being linked))
#Comment by Krinkle (talk | contribs)   15:01, 8 May 2011
  • trunk/extensions/SemanticResultFormats/compat/Html.php
 	          * Convenience function to produce an input element with type=hidden, like
-	          * Xml::hidden.
+	          * Html::hidden.
	          *
 	          * @param
#Comment by Reedy (talk | contribs)   15:03, 8 May 2011

Basically just stuff sitting around in my w/c at the same time, was easier just to commit them

First was unused variable

2nd was just relevant documentation

3rd was unused

4th when corrected is wrong

Status & tagging log