r87594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87593‎ | r87594 | r87595 >
Date:23:07, 6 May 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove addExtraSQL
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRandompage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1975,7 +1975,7 @@
19761976 return '';
19771977 }
19781978 return Xml::expandAttributes( array(
1979 - 'title' => self::titleAttrib( $name, $options )
 1979+ 'title' => $tooltip
19801980 ) );
19811981 }
19821982 }
Index: trunk/phase3/includes/specials/SpecialRandompage.php
@@ -132,9 +132,6 @@
133133 if ( $wgExtraRandompageSQL ) {
134134 $this->extra[] = $wgExtraRandompageSQL;
135135 }
136 - if ( $this->addExtraSQL() ) {
137 - $this->extra[] = $this->addExtraSQL();
138 - }
139136
140137 return array(
141138 'tables' => array( 'page' ),
@@ -168,12 +165,4 @@
169166
170167 return $dbr->fetchObject( $res );
171168 }
172 -
173 - /** an alternative to $wgExtraRandompageSQL so subclasses
174 - * can add their own SQL by overriding this function
175 - * @deprecated since 1.16 append to $this->extra instead
176 - */
177 - public function addExtraSQL() {
178 - return '';
179 - }
180169 }

Status & tagging log