r87587 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87586‎ | r87587 | r87588 >
Date:21:57, 6 May 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1299,12 +1299,7 @@
13001300 * @return Bool True if rate limited
13011301 */
13021302 public function isPingLimitable() {
1303 - global $wgRateLimitsExcludedGroups;
13041303 global $wgRateLimitsExcludedIPs;
1305 - if( array_intersect( $this->getEffectiveGroups(), $wgRateLimitsExcludedGroups ) ) {
1306 - // Deprecated, but kept for backwards-compatibility config
1307 - return false;
1308 - }
13091304 if( in_array( wfGetIP(), $wgRateLimitsExcludedIPs ) ) {
13101305 // No other good way currently to disable rate limits
13111306 // for specific IPs. :P
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3670,17 +3670,6 @@
36713671 $wgRateLimitLog = null;
36723672
36733673 /**
3674 - * Array of groups which should never trigger the rate limiter
3675 - *
3676 - * @deprecated since 1.13.0, the preferred method is using
3677 - * $wgGroupPermissions[]['noratelimit']. However, this will still
3678 - * work if desired.
3679 - *
3680 - * $wgRateLimitsExcludedGroups = array( 'sysop', 'bureaucrat' );
3681 - */
3682 -$wgRateLimitsExcludedGroups = array();
3683 -
3684 -/**
36853674 * Array of IPs which should be excluded from rate limits.
36863675 * This may be useful for whitelisting NAT gateways for conferences, etc.
36873676 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r87604List all removed globals in my recent commits in RELEASE-NOTESreedy23:39, 6 May 2011

Comments

#Comment by Siebrand (talk | contribs)   17:44, 7 May 2011

Should this type of change be in RELEASE-NOTES? Not sure what my opinion is. I do recognise however that it's not always clear to me which when to include something or not... Are there any guidelines?

#Comment by 😂 (talk | contribs)   17:53, 7 May 2011

When it doubt, it goes in the RELEASE-NOTES.

This should definitely be there, since we're removing back-compat.

#Comment by Siebrand (talk | contribs)   17:56, 7 May 2011

Then reedy will, unfortunately, have to get busy updating the release notes for many more revs - he's been doing a lot of work on it (thanks Sam!)

#Comment by Siebrand (talk | contribs)   17:57, 7 May 2011

Ugh. Fixed in r87604. Please use the follow-up revs, Sam :)

Status & tagging log