r87490 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87489‎ | r87490 | r87491 >
Date:09:12, 5 May 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
Fix PHP notice in r85922. Sorry for the holdup, I kinda forgot about it
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
——@@ -1085,7 +1085,7 @@
10861086 }
10871087 $return .= "\n</tr>";
10881088
1089 - if ( ( !isset( $table[$i + 1] ) && !$simple ) || ( isset( $table[$i + 1] ) && ( $table[$i]['type'] != $table[$i + 1]['type'] ) ) ) {
 1089+ if ( ( !isset( $table[$i + 1] ) && !$simple ) || ( isset( $table[$i + 1] ) && isset( $table[$i + 1]['type'] ) && $table[$i]['type'] != $table[$i + 1]['type'] ) ) {
10901090 $return .= '</' . $table[$i]['type'] . '>';
10911091 }
10921092 $lastSection = $table[$i]['type'];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85922diebuche21:27, 12 April 2011

Comments

#Comment by Nikerabbit (talk | contribs)   09:14, 5 May 2011

Thanks!

#Comment by Platonides (talk | contribs)   16:23, 6 May 2011

Are you guaranteed that $table[$i]['type'] is also set?

#Comment by DieBuche (talk | contribs)   16:37, 6 May 2011

Yep. It's enforced in L1050

#Comment by Platonides (talk | contribs)   21:06, 6 May 2011

Right

Status & tagging log