r87489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87488‎ | r87489 | r87490 >
Date:08:26, 5 May 2011
Author:maxsem
Status:ok
Tags:
Comment:
1.17: MFT r87488 (fatal on web upgrade)
Modified paths:
  • /branches/REL1_17/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/installer/WebInstallerPage.php
@@ -244,7 +244,9 @@
245245 // If there is no $wgUpgradeKey, tell the user to add one to LocalSettings.php
246246 if ( $vars['wgUpgradeKey'] === false ) {
247247 if ( $this->getVar( 'wgUpgradeKey', false ) === false ) {
248 - $this->parent->generateUpgradeKey();
 248+ $secretKey = $this->getVar( 'wgSecretKey' ); // preserve $wgSecretKey
 249+ $this->parent->generateKeys();
 250+ $this->setVar( 'wgSecretKey', $secretKey );
249251 $this->setVar( '_UpgradeKeySupplied', true );
250252 }
251253 $this->startForm();
Property changes on: branches/REL1_17/phase3/includes/installer/WebInstallerPage.php
___________________________________________________________________
Modified: svn:mergeinfo
252254 Merged /trunk/phase3/includes/installer/WebInstallerPage.php:r87488

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87488Bug 28822 - Upgrade from normal 1.16 wiki to 1.17 fails with fatal errormaxsem08:20, 5 May 2011

Status & tagging log