r87412 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87411‎ | r87412 | r87413 >
Date:17:20, 4 May 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Add i18n file for r87365
Add extension to Translatewiki
Modified paths:
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)
  • /trunk/extensions/WhitelistPages/WhitelistPages.i18n.php (added) (history)
  • /trunk/extensions/WhitelistPages/WhitelistPages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -1743,6 +1743,9 @@
17441744 White List Edit
17451745 aliasfile = WhiteListEdit/WhiteListEdit.alias.php
17461746
 1747+Whitelist Pages
 1748+ignored = public_read_whitelist
 1749+
17471750 Whos Online
17481751 aliasfile = WhosOnline/WhosOnline.alias.php
17491752
Index: trunk/extensions/WhitelistPages/WhitelistPages.i18n.php
@@ -0,0 +1,15 @@
 2+<?php
 3+/**
 4+ * Internationalisation file for extension Whitelist Pages.
 5+ *
 6+ * @file
 7+ * @ingroup Extensions
 8+ */
 9+
 10+$messages = array();
 11+
 12+$messages['en'] = array(
 13+ 'whitelistpages-desc' => 'Allows [[MediaWiki:Public read whitelist|whitelisting]] pages on a private wiki so that anonymous users can read said pages',
 14+ 'public_read_whitelist' => '',
 15+);
 16+
Property changes on: trunk/extensions/WhitelistPages/WhitelistPages.i18n.php
___________________________________________________________________
Added: svn:eol-style
117 + native
Index: trunk/extensions/WhitelistPages/WhitelistPages.php
@@ -18,13 +18,16 @@
1919
2020 // Extension credits that will show up on Special:Version
2121 $wgExtensionCredits['other'][] = array(
 22+ 'path' => __FILE__,
2223 'name' => 'Whitelist Pages',
2324 'author' => array( 'Jack Phoenix', 'Misza' ),
24 - 'version' => '0.2',
25 - 'description' => 'Allows [[MediaWiki:Public read whitelist|whitelisting]] pages on a private wiki so that anonymous users can read said pages',
 25+ 'version' => '0.2.1',
 26+ 'descriptionmsg' => 'whitelistpages-desc',
2627 'url' => 'http://www.mediawiki.org/wiki/Extension:Whitelist_Pages',
2728 );
2829
 30+$wgExtensionMessagesFiles['WhitelistPages'] = dirname( __FILE__ ) . '/WhitelistPages.i18n.php';
 31+
2932 $wgExtensionFunctions[] = 'wfWhitelistPages';
3033 function wfWhitelistPages() {
3134 global $wgWhitelistRead, $wgGroupPermissions;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87365commit some ShoutWiki extensions from MediaWiki.org because ^demon has Evil P...ashley23:06, 3 May 2011

Comments

#Comment by Jack Phoenix (talk | contribs)   17:25, 4 May 2011

I don't think that this extension needs an i18n file (see also User:Jack Phoenix/extension stuff); extensions that actually have some translatable strings, besides the description shown on Special:Version, such as Extension:ProtectSite can and should be translated. :)

#Comment by Raymond (talk | contribs)   17:28, 4 May 2011

Most extensions have an i18n file at least for the description message shown on Special:Version

Especially for WhitelistPages: With this i18n file the config message "public_read_whitelist" is visible on Special:AllMessages

Status & tagging log