r87411 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87410‎ | r87411 | r87412 >
Date:17:17, 4 May 2011
Author:pcopp
Status:resolved (Comments)
Tags:
Comment:
Follow-up r87394: Add reference back to MediaWiki::performRequestForTitle per IAlex' comment.
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
——@@ -1,4 +1,4 @@
2 -<?php
 2+f<?php
33 /**
44 * MediaWiki is the to-be base class for this whole project
55 *
——@@ -67,7 +67,7 @@
6868 *
6969 * @param $article Article
7070 */
71 - public function performRequestForTitle( $article ) {
 71+ public function performRequestForTitle( &$article ) {
7272 wfProfileIn( __METHOD__ );
7373
7474 if ( $this->context->request->getVal( 'printable' ) === 'yes' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r87413Follow-up r87411: Remove stray fraymond17:23, 4 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87394Remove references from function parameters in Wiki.php. They aren't needed fo...pcopp11:50, 4 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:13, 5 May 2011

Can we have the pre-commit php -l hook back?

#Comment by 😂 (talk | contribs)   07:14, 5 May 2011

I never removed it, it just isn't working.

Status & tagging log