r87339 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87338‎ | r87339 | r87340 >
Date:17:21, 3 May 2011
Author:mah
Status:ok (Comments)
Tags:todo 
Comment:
Fixes bug #28694: Set maxlength of revisiondelete comment to 100.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialRevisiondelete.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisiondelete.php
——@@ -404,7 +404,7 @@
405405 Xml::label( wfMsg( 'revdelete-otherreason' ), 'wpReason' ) .
406406 '</td>' .
407407 '<td class="mw-input">' .
408 - Xml::input( 'wpReason', 60, $this->otherReason, array( 'id' => 'wpReason' ) ) .
 408+ Xml::input( 'wpReason', 60, $this->otherReason, array( 'id' => 'wpReason', 'maxlength' => 100 ) ) .
409409 '</td>' .
410410 "</tr><tr>\n" .
411411 '<td></td>' .

Comments

#Comment by Bawolff (talk | contribs)   18:43, 3 May 2011

Presumably this limit is due to limitation on db end? We should probably use the byteCounting js so that it works properly with multi-byte utf-8 characters properly (since the db limit would be a byte limit not a character limit), like is done in resources/mediawiki.special/mediawiki.special.movePage.js.

#Comment by Brion VIBBER (talk | contribs)   19:11, 7 June 2011

Should indeed be more generalized. 100 chars is also pretty short! Marking as a todo rather than a fixme though.

Status & tagging log