r87338 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87337‎ | r87338 | r87339 >
Date:17:21, 3 May 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
(bug 28723) Email confirmation interface messages are not up to date
Modified paths:
  • /trunk/extensions/EmailCapture/EmailCapture.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/EmailCapture/EmailCapture.i18n.php
@@ -16,16 +16,23 @@
1717 'emailcapture-desc' => 'Capture e-mail addresses, and allow users to verify them through e-mail',
1818 'emailcapture-failure' => "Your e-mail was '''not''' verified.",
1919 'emailcapture-response-subject' => '{{SITENAME}} e-mail address verification',
20 - 'emailcapture-response-body' => 'Verify your e-mail address by following this link:
 20+ 'emailcapture-response-body' => 'Hello!
 21+
 22+Thank you for for expressing interest in helping to improve {{SITENAME}}.
 23+
 24+Please take a moment to confirm your email by clicking on the link below:
2125 $1
2226
23 -You can also visit:
 27+You may also visit:
2428 $2
2529
26 -and enter the following verification code:
 30+And enter the following confirmation cod:
2731 $3
2832
29 -Thank you for verifying your e-mail address.',
 33+We’ll be in touch shortly with how you can help improve {{SITENAME}}.
 34+
 35+If you didn’t initiate this request, please ignore this email and we won’t send you anything else.
 36+',
3037 'emailcapture-success' => 'Your e-mail address was successfully verified.',
3138 'emailcapture-instructions' => 'To verify your e-mail address, enter the code that was emailed to you and click "{{int:emailcapture-submit}}".',
3239 'emailcapture-verify' => 'Verification code:',

Follow-up revisions

RevisionCommit summaryAuthorDate
r87341(bug 28723) Email confirmation interface messages are not up to datekrinkle17:24, 3 May 2011
r87342typokrinkle17:36, 3 May 2011

Comments

#Comment by Mormegil (talk | contribs)   16:23, 16 June 2011

This commit introduced nonuniformity in the terminology (confirmation vs. verification, confirm/verify etc.), which was fixed only partially in the subsequent commits. Cf. MediaWiki:Emailcapture-success vs. MediaWiki:Emailcapture-failure, MediaWiki:Emailcapture-verify, …

#Comment by Krinkle (talk | contribs)   17:30, 16 June 2011

I suggest switching to 'confirm' as that's also used in MediaWiki core for similar action.

Status & tagging log