r87293 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87292‎ | r87293 | r87294 >
Date:20:30, 2 May 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
bugfix: scrollTop for popupform was incorrectly set for some browsers
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -504,9 +504,12 @@
505505 // find the dimensions of the document
506506
507507 var html = content.closest('html');
508 - var scrollTgt = html;
509508
510 - if( jQuery.browser.webkit || jQuery.browser.safari ){
 509+ var scrollTgt;
 510+
 511+ if ( jQuery.browser.msie || jQuery.browser.opera ) {
 512+ scrollTgt = html;
 513+ } else {
511514 scrollTgt = content.closest('body');
512515 }
513516
@@ -535,15 +538,13 @@
536539 .width( oldContW )
537540 .height( oldContH );
538541
539 - var docW, docH;
540 -
541542 if ( jQuery.browser.msie ) {
542543 docW += 20;
543544 docH += 20;
544545 }
545546
546 - docpW = docW + 2 * padding;
547 - docpH = docH + 2 * padding;
 547+ var docpW = docW + 2 * padding;
 548+ var docpH = docH + 2 * padding;
548549
549550 // Flags
550551

Follow-up revisions

RevisionCommit summaryAuthorDate
r87295followup r87293: partial revert, was not a bug in popupform after allfoxtrott20:51, 2 May 2011