r87295 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87294‎ | r87295 | r87296 >
Date:20:51, 2 May 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r87293: partial revert, was not a bug in popupform after all
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SF_popupform.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SF_popupform.js
@@ -505,11 +505,9 @@
506506
507507 var html = content.closest('html');
508508
509 - var scrollTgt;
 509+ var scrollTgt = html;
510510
511 - if ( jQuery.browser.msie || jQuery.browser.opera ) {
512 - scrollTgt = html;
513 - } else {
 511+ if ( jQuery.browser.webkit || jQuery.browser.safari ) {
514512 scrollTgt = content.closest('body');
515513 }
516514

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87293bugfix: scrollTop for popupform was incorrectly set for some browsersfoxtrott20:30, 2 May 2011