r87261 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r87260‎ | r87261 | r87262 >
Date:17:32, 2 May 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
A few minor RSD changes
Modified paths:
  • /trunk/phase3/includes/api/ApiRsd.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiRsd.php
——@@ -47,7 +47,8 @@
4848
4949 $service = array( 'apis' => $this->formatRsdApiList() );
5050 ApiResult::setContent( $service, 'MediaWiki', 'engineName' );
51 - ApiResult::setContent( $service, 'http://www.mediawiki.org/', 'engineLink' );
 51+ ApiResult::setContent( $service, 'http://www.mediawiki.org/w/api.php', 'engineLink' );
 52+ ApiResult::setContent( $service, 'http://www.mediawiki.org/', 'homePageLink' );
5253
5354 $result->setIndexedTagName( $service['apis'], 'api' );
5455
——@@ -67,7 +68,7 @@
6869 }
6970
7071 public function getDescription() {
71 - return 'Export an RSD schema';
 72+ return 'Export an RSD (Really Simple Discovery) schema';
7273 }
7374
7475 protected function getExamples() {
——@@ -100,7 +101,7 @@
101102 'apiLink' => wfExpandUrl( wfScript( 'api' ) ),
102103
103104 // Docs link is optional, but recommended.
104 - 'docs' => 'http://mediawiki.org/wiki/API',
 105+ 'docs' => 'http://www.mediawiki.org/wiki/API',
105106
106107 // Some APIs may need a blog ID, but it may be left blank.
107108 'blogID' => '',

Follow-up revisions

RevisionCommit summaryAuthorDate
r87631Followup r87261...reedy14:02, 7 May 2011

Comments

#Comment by Bryan (talk | contribs)   13:56, 7 May 2011

I don't think this is correct. The protocol states that <engineLink> is the URL to the home of the engine. The engine is MediaWiki, so it should really just link to the MW home page. Furthermore, <homePageLink> is the URL of the users homepage, so that should in fact link to Title::newMainPage()->getFullUrl(). See also the example in the protocol: 

        <engineName>Blog Munging CMS</engineName> 
        <engineLink>[http://www.blogmunging.com/ http://www.blogmunging.com/] </engineLink>
        <homePageLink>[http://www.userdomain.com/ http://www.userdomain.com/] </homePageLink>

http://tales.phrasewise.com/rfc/rsd

Status & tagging log