r87260 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87259‎ | r87260 | r87261 >
Date:17:30, 2 May 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* Removed Skin::reallyGenerateUserStylesheet() nothing uses it and nothing overrides it
* Corrected Skin::generateUserJs() and Skin::generateUserStylesheet()'s comments: nothing override them anymore, also marked them as deprecated, only usage is action=raw&gen=(css|js)
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -374,47 +374,30 @@
375375
376376 /**
377377 * Generated JavaScript action=raw&gen=js
378 - * This returns MediaWiki:Common.js and MediaWiki:[Skinname].js concate-
379 - * nated together. For some bizarre reason, it does *not* return any
380 - * custom user JS from subpages. Huh?
 378+ * This used to load MediaWiki:Common.js and the skin-specific style
 379+ * before the RessourceLoader.
381380 *
382 - * There's absolutely no reason to have separate Monobook/Common JSes.
383 - * Any JS that cares can just check the skin variable generated at the
384 - * top. For now Monobook.js will be maintained, but it should be consi-
385 - * dered deprecated.
386 - *
 381+ * @deprecated Use the RessourceLoader instead. This may be removed at some
 382+ * point.
387383 * @param $skinName String: If set, overrides the skin name
388 - * @return string
 384+ * @return String
389385 */
390386 public function generateUserJs( $skinName = null ) {
391 -
392 - // Stub - see ResourceLoaderSiteModule, CologneBlue, Simple and Standard skins override this
393 -
394387 return '';
395388 }
396389
397390 /**
398391 * Generate user stylesheet for action=raw&gen=css
 392+ *
 393+ * @deprecated Use the RessourceLoader instead. This may be removed at some
 394+ * point.
 395+ * @return String
399396 */
400397 public function generateUserStylesheet() {
401 -
402 - // Stub - see ResourceLoaderUserModule, CologneBlue, Simple and Standard skins override this
403 -
404398 return '';
405399 }
406400
407401 /**
408 - * Split for easier subclassing in SkinSimple, SkinStandard and SkinCologneBlue
409 - * Anything in here won't be generated if $wgAllowUserCssPrefs is false.
410 - */
411 - protected function reallyGenerateUserStylesheet() {
412 -
413 - // Stub - see ResourceLoaderUserModule, CologneBlue, Simple and Standard skins override this
414 -
415 - return '';
416 - }
417 -
418 - /**
419402 * @private
420403 */
421404 function setupUserCss( OutputPage $out ) {

Comments

#Comment by Nikerabbit (talk | contribs)   17:37, 2 May 2011

RessourceLoader

Status & tagging log