r87150 MediaWiki - Code Review archive

>Essentially what SpecialVersion will give you if wgSpecialVersionShowHooks is true

Should $wgSpecialVersionShowHooks not check also on the api? It is disabled by default, so this revision introduce a way around that config.

Agreed, that config option was added because some people considered it undesireable for a list of registered hooks to be exposed to spammers or people trying to break the wiki who could use it to figure out things about how the wiki was configured.

I'm not sure I quite agree. MediaWiki doesn't have any way of preventing listing of all extension on a wiki, so you can find out the extensions installed, and work it from there. Which has very little to do with "how the wiki was configured"

Unless someone has written a custom spam plugin, (which will happen but be VERY rare), most of them are open source, and you can see some of the "configuration" if you try to signup, or edit as anon.

I did think about that when adding it, but decided it seemed useless, and the option seemed more like additional info some people, but not all would want to see

i.e I'm suggesting that argument is just security through obscurity

+				'subscribers' => $hooks,

Note that the elements of $hooks need not be strings, they may also be objects, or arrays like array( $object, 'method' ) or a bunch of other array formats. See Manual:Hooks#Writing an event handler.

			foreach ( $myWgHooks as $hook => $hooks ) {
				$ret .= "<tr>
						<td>$hook</td>
						<td>" . $this->listToText( $hooks ) . "</td>
					</tr>\n";
			}
<snip>
/**
	 * Convert an array of items into a list for display.
	 *
	 * @param $list Array of elements to display
	 * @param $sort Boolean: whether to sort the items in $list
	 *
	 * @return String
	 */
	function listToText( $list, $sort = true ) {
		$cnt = count( $list );

		if ( $cnt == 1 ) {
			// Enforce always returning a string
			return (string)self::arrayToString( $list[0] );
		} elseif ( $cnt == 0 ) {
			return '';
		} else {
			global $wgLang;
			if ( $sort ) {
				sort( $list );
			}
			return $wgLang->listToText( array_map( array( __CLASS__, 'arrayToString' ), $list ) );
		}
	}

	/**
	 * Convert an array or object to a string for display.
	 *
	 * @param $list Mixed: will convert an array to string if given and return
	 *              the paramater unaltered otherwise
	 *
	 * @return Mixed
	 */
	static function arrayToString( $list ) {
		if( is_array( $list ) && count( $list ) == 1 ) {
			$list = $list[0];
		}
		if( is_object( $list ) ) {
			$class = get_class( $list );
			return "($class)";
		} elseif ( !is_array( $list ) ) {
			return $list;
		} else {
			if( is_object( $list[0] ) ) {
				$class = get_class( $list[0] );
			} else {
				$class = $list[0];
			}
			return "($class, {$list[1]})";
		}
	}

I suppose I could array_map on the items, and check types, if not a string push it through SpecialVersion::arrayToString()

Sounds good. In fact, arrayToString() will take strings just fine (is_array fails, is_object fails !is_array succeeds) so you could just map it unconditionally.