r87151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87150‎ | r87151 | r87152 >
Date:23:34, 29 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Tweak documentation

Add braces
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -5057,7 +5057,6 @@
50585058 * @param $text String
50595059 * @param $frame PPFrame
50605060 * @return String
5061 - * @private
50625061 */
50635062 function attributeStripCallback( &$text, $frame = false ) {
50645063 $text = $this->replaceVariables( $text, $frame );
@@ -5067,6 +5066,8 @@
50685067
50695068 /**
50705069 * Accessor
 5070+ *
 5071+ * @return array
50715072 */
50725073 function getTags() {
50735074 return array_merge( array_keys( $this->mTransparentTagHooks ), array_keys( $this->mTagHooks ) );
Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
@@ -267,7 +267,7 @@
268268 * @param $prop Array of properties to get (in the keys)
269269 * @param $result ApiResult object
270270 * @param $thumbParams Array containing 'width' and 'height' items, or null
271 - * @param $version Version of image metadata (for things like jpeg which have different versions).
 271+ * @param $version string Version of image metadata (for things like jpeg which have different versions).
272272 * @return Array: result array
273273 */
274274 static function getInfo( $file, $prop, $result, $thumbParams = null, $version = 'latest' ) {
Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -470,11 +470,12 @@
471471 <th>" . wfMsg( 'version-hook-subscribedby' ) . "</th>
472472 </tr>\n";
473473
474 - foreach ( $myWgHooks as $hook => $hooks )
 474+ foreach ( $myWgHooks as $hook => $hooks ) {
475475 $ret .= "<tr>
476476 <td>$hook</td>
477477 <td>" . $this->listToText( $hooks ) . "</td>
478478 </tr>\n";
 479+ }
479480
480481 $ret .= Xml::closeElement( 'table' );
481482 return $ret;
@@ -572,10 +573,11 @@
573574 } elseif ( !is_array( $list ) ) {
574575 return $list;
575576 } else {
576 - if( is_object( $list[0] ) )
 577+ if( is_object( $list[0] ) ) {
577578 $class = get_class( $list[0] );
578 - else
 579+ } else {
579580 $class = $list[0];
 581+ }
580582 return "($class, {$list[1]})";
581583 }
582584 }

Status & tagging log