r86845 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86844‎ | r86845 | r86846 >
Date:11:35, 25 April 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 21180) Move the old toolbar below the summary input to match the new toolbar
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1336,7 +1336,6 @@
13371337 // @todo move this to a cleaner conditional instead of blanking a variable
13381338 }
13391339 $wgOut->addHTML( <<<HTML
1340 -{$toolbar}
13411340 <form id="editform" name="editform" method="post" action="$action" enctype="multipart/form-data">
13421341 HTML
13431342 );
@@ -1390,6 +1389,8 @@
13911390 }
13921391
13931392 $wgOut->addHTML( $this->editFormTextBeforeContent );
 1393+
 1394+ $wgOut->addHTML( $toolbar );
13941395
13951396 if ( $this->isConflict ) {
13961397 // In an edit conflict bypass the overrideable content form method

Comments

#Comment by Catrope (talk | contribs)   11:36, 25 April 2011

Forgot to credit Jan Paul Posma, whose patch I committed here.

#Comment by Brion VIBBER (talk | contribs)   21:13, 14 June 2011

Looks good!

Status & tagging log