r86844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86843‎ | r86844 | r86845 >
Date:11:17, 25 April 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
UploadWizard: Add some /* @embed */
Modified paths:
  • /trunk/extensions/UploadWizard/resources/jquery/jquery.arrowSteps.css (modified) (history)
  • /trunk/extensions/UploadWizard/resources/uploadWizard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/jquery/jquery.arrowSteps.css
@@ -20,21 +20,26 @@
2121 }
2222
2323 .arrowSteps li.arrow div {
 24+ /* @embed */
2425 background: url(jquery.arrowSteps.divider.png) no-repeat right center;
2526 }
2627
2728 /* applied to the element preceding the highlighted step */
2829 .arrowSteps li.arrow.tail div {
 30+ /* @embed */
2931 background: url(jquery.arrowSteps.tail.png) no-repeat right center;
3032 }
3133
3234 /* this applies to all highlighted, including the last */
3335 .arrowSteps li.head div {
 36+ /* @embed */
3437 background: url(jquery.arrowSteps.head.png) no-repeat left center;
3538 font-weight: bold;
3639 }
3740
3841 /* this applies to all highlighted arrows except the last */
3942 .arrowSteps li.arrow.head div {
 43+ /* TODO: eliminate duplication of jquery.arrowSteps.head.png embedding */
 44+ /* @embed */
4045 background: url(jquery.arrowSteps.head.png) no-repeat right center;
4146 }
Index: trunk/extensions/UploadWizard/resources/uploadWizard.css
@@ -173,12 +173,14 @@
174174 padding: 0.5em;
175175 border: 1px solid #e0e0e0;
176176 margin-right: 1em;
 177+ /* @embed */
177178 background: url('images/32px-Blank-document.svg.png') no-repeat center center;
178179 }
179180
180181 .mwe-upwiz-file-preview-broken {
181182 height: 60px !important;
182183 width: 60px !important;
 184+ /* @embed */
183185 background: url('images/32px-Blank-document-broken.svg.png') no-repeat center center !important;
184186 }
185187
@@ -284,17 +286,21 @@
285287 }
286288
287289 .mwe-upwiz-status-progress {
 290+ /* @embed */
288291 background: url('images/24px-spinner-0645ad.gif') no-repeat center center;
289292 }
290293
291294 .mwe-upwiz-file.hover .mwe-upwiz-status-progress {
 295+ /* @embed */
292296 background: url('images/24px-spinner-0645ad-e0f0ff.gif') no-repeat center center;
293297 }
294298
295299 .mwe-upwiz-file.odd .mwe-upwiz-status-progress {
 300+ /* @embed */
296301 background: url('images/24px-spinner-0645ad-f5f5f5.gif') no-repeat center center;
297302 }
298303 .mwe-upwiz-status-stashed, .mwe-upwiz-status-uploaded {
 304+ /* @embed */
299305 background: url('images/32px-Dialog-apply-009900.svg.png') no-repeat center center;
300306 }
301307
@@ -307,18 +313,22 @@
308314 }
309315
310316 .mwe-upwiz-cc-zero-icon {
 317+ /* @embed */
311318 background: url('images/18px-Cc-zero.svg.png') no-repeat center center;
312319 }
313320
314321 .mwe-upwiz-cc-sa-icon {
 322+ /* @embed */
315323 background: url('images/18px-Share_Alike.svg.png') no-repeat center center;
316324 }
317325
318326 .mwe-upwiz-cc-by-icon {
 327+ /* @embed */
319328 background: url('images/18px-Cc-by_new_white.svg.png') no-repeat center center;
320329 }
321330
322331 .mwe-upwiz-status-error {
 332+ /* @embed */
323333 background: url('images/32px-Nuvola_apps_important_orange.svg.png') no-repeat center center;
324334 font-weight: bold;
325335 color: #CC0000;
@@ -612,10 +622,12 @@
613623 .mwe-upwiz-toggler {
614624 margin-bottom: 0;
615625 padding: 4px 0 3px 18px;
 626+ /* @embed */
616627 background: url('images/toggle.png') no-repeat left center;
617628 }
618629
619630 .mwe-upwiz-toggler-open {
 631+ /* @embed */
620632 background: url('images/toggle-open.png') no-repeat left center;
621633 }
622634
@@ -647,6 +659,7 @@
648660
649661 .mwe-date {
650662 width: 20em;
 663+ /* @embed */
651664 background: #ffffff url('images/calendar.gif') no-repeat right center;
652665 }
653666
@@ -655,6 +668,7 @@
656669 }
657670
658671 .mwe-upwiz-hint {
 672+ /* @embed */
659673 background: url('images/question.png') no-repeat;
660674 display: inline-block;
661675 height: 11px;
@@ -662,6 +676,7 @@
663677 margin-left: 4px;
664678 }
665679 .mwe-upwiz-hint:hover {
 680+ /* @embed */
666681 background: url('images/question-hover.png') no-repeat;
667682 }
668683

Comments

#Comment by NeilK (talk | contribs)   14:47, 25 April 2011

I am assuming this is ResourceLoader magic.

#Comment by Catrope (talk | contribs)   18:19, 25 April 2011

Yes, it triggers data URL embedding.

Status & tagging log