r86043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86042‎ | r86043 | r86044 >
Date:11:58, 14 April 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Fix regression introduced in r82451. Only happens when getAllHeaders was not called before LanguageSelector hook was executed, not sure in which conditions this happens or not.
Modified paths:
  • /trunk/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebRequest.php
——@@ -734,6 +734,7 @@
735735 * @param $name String: case-insensitive header name
736736 */
737737 public function getHeader( $name ) {
 738+ $this->initHeaders();
738739 $name = strtoupper( $name );
739740 if ( isset( $this->headers[$name] ) ) {
740741 return $this->headers[$name];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82451Merged retrieval of request URL and header from WebRequest and Setup.php to a...ialex13:09, 19 February 2011

Comments

#Comment by IAlex (talk | contribs)   12:10, 14 April 2011

Thanks for the fix!

Status & tagging log