r86042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86041‎ | r86042 | r86043 >
Date:11:37, 14 April 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Move $rxTc initialization next to where it is used
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -2569,8 +2569,6 @@
25702570 global $wgContLang, $wgLocalInterwiki;
25712571
25722572 # Initialisation
2573 - $rxTc = self::getTitleInvalidRegex();
2574 -
25752573 $this->mInterwiki = $this->mFragment = '';
25762574 $this->mNamespace = $this->mDefaultNamespace; # Usually NS_MAIN
25772575
@@ -2680,6 +2678,7 @@
26812679 }
26822680
26832681 # Reject illegal characters.
 2682+ $rxTc = self::getTitleInvalidRegex();
26842683 if ( preg_match( $rxTc, $dbkey ) ) {
26852684 return false;
26862685 }

Status & tagging log