r85849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85848‎ | r85849 | r85850 >
Date:01:26, 12 April 2011
Author:tstarling
Status:ok
Tags:
Comment:
Check all MSIE requests since we also want to protect IE 3-5 etc.
Modified paths:
  • /trunk/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebRequest.php
@@ -788,10 +788,10 @@
789789 && preg_match( '/\.[a-z]{1,4}$/i', $_SERVER['QUERY_STRING'] ) )
790790 {
791791 // Bug 28235
792 - // Block only Internet Explorer 6, and requests with missing UA
 792+ // Block only Internet Explorer, and requests with missing UA
793793 // headers that could be IE users behind a privacy proxy.
794794 if ( !isset( $_SERVER['HTTP_USER_AGENT'] )
795 - || preg_match( '/; *MSIE 6/', $_SERVER['HTTP_USER_AGENT'] ) )
 795+ || preg_match( '/; *MSIE/', $_SERVER['HTTP_USER_AGENT'] ) )
796796 {
797797 return true;
798798 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r85850MFT r85849: Check all MSIE requests since we also want to protect IE 3-5 etc.tstarling01:27, 12 April 2011
r85852MFT r85849: Check all MSIE requests since we also want to protect IE 3-5 etc.tstarling01:27, 12 April 2011
r85853MFT r85849: Check all MSIE requests since we also want to protect IE 3-5 etc.tstarling01:28, 12 April 2011

Status & tagging log