r85852 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85851‎ | r85852 | r85853 >
Date:01:27, 12 April 2011
Author:tstarling
Status:ok
Tags:
Comment:
MFT r85849: Check all MSIE requests since we also want to protect IE 3-5 etc.
Modified paths:
  • /branches/REL1_17/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/WebRequest.php
@@ -758,10 +758,10 @@
759759 && preg_match( '/\.[a-z]{1,4}$/i', $_SERVER['QUERY_STRING'] ) )
760760 {
761761 // Bug 28235
762 - // Block only Internet Explorer 6, and requests with missing UA
 762+ // Block only Internet Explorer, and requests with missing UA
763763 // headers that could be IE users behind a privacy proxy.
764764 if ( !isset( $_SERVER['HTTP_USER_AGENT'] )
765 - || preg_match( '/; *MSIE 6/', $_SERVER['HTTP_USER_AGENT'] ) )
 765+ || preg_match( '/; *MSIE/', $_SERVER['HTTP_USER_AGENT'] ) )
766766 {
767767 return true;
768768 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85849Check all MSIE requests since we also want to protect IE 3-5 etc.tstarling01:26, 12 April 2011

Status & tagging log