r85193 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85192‎ | r85193 | r85194 >
Date:14:48, 2 April 2011
Author:ashley
Status:ok
Tags:
Comment:
mark some public functions as such
Modified paths:
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -154,10 +154,8 @@
155155
156156 /**
157157 * Constructor
158 - *
159 - * @public
160158 */
161 - function __construct( $conf = array() ) {
 159+ public function __construct( $conf = array() ) {
162160 $this->mConf = $conf;
163161 $this->mUrlProtocols = wfUrlProtocols();
164162 $this->mExtLinkBracketedRegex = '/\[(\b(' . wfUrlProtocols() . ')'.
Index: trunk/phase3/includes/filerepo/File.php
@@ -452,9 +452,8 @@
453453 * It would be unsafe to include private images, making public thumbnails inadvertently
454454 *
455455 * @return boolean Whether file exists in the repository and is includable.
456 - * @public
457456 */
458 - function isVisible() {
 457+ public function isVisible() {
459458 return $this->exists();
460459 }
461460

Follow-up revisions

RevisionCommit summaryAuthorDate
r85196follow-up to r85193: missed one fileashley14:53, 2 April 2011

Status & tagging log