r85196 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85195‎ | r85196 | r85197 >
Date:14:53, 2 April 2011
Author:ashley
Status:ok
Tags:
Comment:
follow-up to r85193: missed one file
Modified paths:
  • /trunk/phase3/includes/parser/Parser_LinkHooks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser_LinkHooks.php
@@ -9,8 +9,7 @@
1010 * Parser with LinkHooks experiment
1111 * @ingroup Parser
1212 */
13 -class Parser_LinkHooks extends Parser
14 -{
 13+class Parser_LinkHooks extends Parser {
1514 /**
1615 * Update this version number when the ParserOutput format
1716 * changes in an incompatible way, so the parser cache
@@ -38,10 +37,8 @@
3938
4039 /**
4140 * Constructor
42 - *
43 - * @public
4441 */
45 - function __construct( $conf = array() ) {
 42+ public function __construct( $conf = array() ) {
4643 parent::__construct( $conf );
4744 $this->mLinkHooks = array();
4845 }
@@ -82,8 +79,6 @@
8380 * True) (Treat as link) Parse the link according to normal link rules
8481 * False) (Bad link) Just output the raw wikitext (You may modify the text first)
8582 *
86 - * @public
87 - *
8883 * @param $ns Integer or String: the Namespace ID or regex pattern if SLH_PATTERN is set
8984 * @param $callback Mixed: the callback function (and object) to use
9085 * @param $flags Integer: a combination of the following flags:
@@ -91,7 +86,7 @@
9287 *
9388 * @return The old callback function for this name, if any
9489 */
95 - function setLinkHook( $ns, $callback, $flags = 0 ) {
 90+ public function setLinkHook( $ns, $callback, $flags = 0 ) {
9691 if( $flags & SLH_PATTERN && !is_string($ns) )
9792 throw new MWException( __METHOD__.'() expecting a regex string pattern.' );
9893 elseif( $flags | ~SLH_PATTERN && !is_int($ns) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85193mark some public functions as suchashley14:48, 2 April 2011

Status & tagging log