r85128 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85127‎ | r85128 | r85129 >
Date:15:57, 1 April 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation logging, bug 19161). Per the *extremely lengthy* discussion that is still ongoing, this fails to solve the underlying problem and has undesired side-effects.

I don't know what the proper solution is (other than introducing user preferences, like bug 28369 suggests, is not the answer)...but the status quo of what we had is better than this half-assed solution that *nobody* likes.
Modified paths:
  • /trunk/phase3/HISTORY (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/HISTORY
@@ -19,8 +19,6 @@
2020 === Configuration changes in 1.17 ===
2121 * DatabaseFunctions.php that was needed for compatibility with pre-1.3
2222 extensions has been removed.
23 -* $wgLogAutocreatedAccounts controls whether autocreation of accounts is logged
24 - to new users log.
2523 * $wgAllowImageTag can be set to true to whitelist the <img> tag in wikitext.
2624 * (bug 12797) Add $wgGalleryOptions for adjusting of default gallery display
2725 options.
Index: trunk/phase3/includes/User.php
@@ -3699,8 +3699,8 @@
37003700 * Used by things like CentralAuth and perhaps other authplugins.
37013701 */
37023702 public function addNewUserLogEntryAutoCreate() {
3703 - global $wgNewUserLog, $wgLogAutocreatedAccounts;
3704 - if( !$wgNewUserLog || !$wgLogAutocreatedAccounts ) {
 3703+ global $wgNewUserLog;
 3704+ if( !$wgNewUserLog ) {
37053705 return true; // disabled
37063706 }
37073707 $log = new LogPage( 'newusers', false );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -4915,11 +4915,6 @@
49164916 */
49174917 $wgNewUserLog = true;
49184918
4919 -/**
4920 - * Log the automatic creations of new users accounts?
4921 - */
4922 -$wgLogAutocreatedAccounts = false;
4923 -
49244919 /** @} */ # end logging }
49254920
49264921 /*************************************************************************//**

Follow-up revisions

RevisionCommit summaryAuthorDate
r88203MFT r85128demon21:01, 15 May 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64853Add $wgLogAutocreatedAccounts to enable/disable account autocreation logging.vasilievvv06:21, 10 April 2010

Comments

#Comment by Platonides (talk | contribs)   16:34, 1 April 2011

This was in core??

#Comment by 😂 (talk | contribs)   16:24, 2 April 2011

Yes, which means it actually affected any auth plugin that auto-creates accounts, not just CentralAuth.

Status & tagging log