r64853 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64852‎ | r64853 | r64854 >
Date:06:21, 10 April 2010
Author:vasilievvv
Status:reverted (Comments)
Tags:
Comment:
Add $wgLogAutocreatedAccounts to enable/disable account autocreation logging.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -3602,8 +3602,8 @@
36033603 * Used by things like CentralAuth and perhaps other authplugins.
36043604 */
36053605 public function addNewUserLogEntryAutoCreate() {
3606 - global $wgNewUserLog;
3607 - if( empty( $wgNewUserLog ) ) {
 3606+ global $wgNewUserLog, $wgLogAutocreatedAccounts;
 3607+ if( !$wgNewUserLog || !$wgLogAutocreatedAccounts ) {
36083608 return true; // disabled
36093609 }
36103610 $log = new LogPage( 'newusers', false );
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3328,6 +3328,11 @@
33293329 $wgNewUserLog = true;
33303330
33313331 /**
 3332+ * Log the automatic creations of new users accounts?
 3333+ */
 3334+$wgLogAutocreatedAccounts = false;
 3335+
 3336+/**
33323337 * List of special pages, followed by what subtitle they should go under
33333338 * at Special:SpecialPages
33343339 */
Index: trunk/phase3/RELEASE-NOTES
@@ -21,6 +21,8 @@
2222 === Configuration changes in 1.17 ===
2323 * DatabaseFunctions.php that was needed for compatibility with pre-1.3
2424 extensions has been removed.
 25+* $wgLogAutocreatedAccounts controls whether autocreation of accounts is logged
 26+ to new users log.
2527
2628 === New features in 1.17 ===
2729 * (bug 10183) Users can now add personal styles and scripts to all skins via

Follow-up revisions

RevisionCommit summaryAuthorDate
r85128Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocr...demon15:57, 1 April 2011

Comments

#Comment by 😂 (talk | contribs)   03:26, 11 February 2011

This is a change in behavior (see bug 27287). People expect to see the log entries, so this will need to be true for WMF sites.

Status & tagging log