r84971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84970‎ | r84971 | r84972 >
Date:17:34, 29 March 2011
Author:demon
Status:resolved
Tags:
Comment:
minor cleanup
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)
  • /trunk/phase3/maintenance/install.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install.php
@@ -63,22 +63,14 @@
6464 $installer =
6565 new CliInstaller( $siteName, $adminName, $this->mOptions );
6666
67 - if ( $this->hasOption( 'env-checks' ) ) {
68 - $status = $installer->doEnvironmentChecks();
69 - if( $status->isGood() ) {
70 - $installer->showMessage( 'config-env-good' );
71 - } else {
72 - $installer->showStatusMessage( $status );
73 - return;
74 - }
 67+ $status = $installer->doEnvironmentChecks();
 68+ if( $status->isGood() ) {
 69+ $installer->showMessage( 'config-env-good' );
7570 } else {
76 - $status = $installer->doEnvironmentChecks();
77 - if( $status->isGood() ) {
78 - $installer->showMessage( 'config-env-good' );
79 - } else {
80 - $installer->showStatusMessage( $status );
81 - return;
82 - }
 71+ $installer->showStatusMessage( $status );
 72+ return;
 73+ }
 74+ if( !$this->getVar( 'env-checks' ) ) {
8375 $installer->execute();
8476 $installer->writeConfigurationFile( $this->getOption( 'confpath', $IP ) );
8577 }
Index: trunk/phase3/includes/installer/Installer.php
@@ -607,13 +607,10 @@
608608 $allNames = array();
609609
610610 foreach ( self::getDBTypes() as $name ) {
611 - $db = $this->getDBInstaller( $name );
612 - $readableName = wfMsg( 'config-type-' . $name );
613 -
614 - if ( $db->isCompiled() ) {
 611+ if ( $this->getDBInstaller( $name )->isCompiled() ) {
615612 $compiledDBs[] = $name;
616613 }
617 - $allNames[] = $readableName;
 614+ $allNames[] = wfMsg( 'config-type-' . $name );;
618615 }
619616
620617 $this->setVar( '_CompiledDBs', $compiledDBs );

Follow-up revisions

RevisionCommit summaryAuthorDate
r85032Fixed fatal in r84971maxsem18:45, 30 March 2011
r85761Remove double ; from r84971...platonides15:54, 10 April 2011

Status & tagging log