r85761 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85760‎ | r85761 | r85762 >
Date:15:54, 10 April 2011
Author:platonides
Status:ok
Tags:
Comment:
Remove double ; from r84971
Make explicit that the previous values of $wgAutoloadClasses are not preserved and make happy the 'unused global' detector.
Modified paths:
  • /trunk/phase3/includes/installer/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.php
@@ -610,7 +610,7 @@
611611 if ( $this->getDBInstaller( $name )->isCompiled() ) {
612612 $compiledDBs[] = $name;
613613 }
614 - $allNames[] = wfMsg( 'config-type-' . $name );;
 614+ $allNames[] = wfMsg( 'config-type-' . $name );
615615 }
616616
617617 $this->setVar( '_CompiledDBs', $compiledDBs );
@@ -1194,6 +1194,8 @@
11951195 * @see https://bugzilla.wikimedia.org/show_bug.cgi?id=26857
11961196 */
11971197 global $wgAutoloadClasses;
 1198+ $wgAutoloadClasses = array();
 1199+
11981200 require( "$IP/includes/DefaultSettings.php" );
11991201
12001202 foreach( $exts as $e ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84971minor cleanupdemon17:34, 29 March 2011

Status & tagging log