r84852 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84851‎ | r84852 | r84853 >
Date:16:19, 27 March 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Add "improveme" for bug 28274
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)
  • /trunk/extensions/CodeReview/modules/ext.codereview.css (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -230,7 +230,7 @@
231231 * @return Array
232232 */
233233 public static function getPossibleStates() {
234 - return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred', 'old' );
 234+ return array( 'new', 'fixme', 'improveme', 'reverted', 'resolved', 'ok', 'deferred', 'old' );
235235 }
236236
237237 /**
Index: trunk/extensions/CodeReview/codereview.sql
@@ -48,6 +48,7 @@
4949 -- Status key for how this thang is...
5050 -- 'new': Hasn't yet been reviewed
5151 -- 'fixme': This revision has some problem which needs to be resolved
 52+ -- 'improveme': This revision has no major errors, but needs further work
5253 -- 'reverted': Was completely reverted by a later revision
5354 -- 'resolved': Issues with this rev have been since resolved
5455 -- 'ok': Reviewed, no issues spotted
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -96,6 +96,8 @@
9797 'code-status-desc-new' => 'Revision is pending an action (default status).',
9898 'code-status-fixme' => 'fixme',
9999 'code-status-desc-fixme' => 'A reviewer marked this revision introduce a bug or is broken. It should be corrected.',
 100+ 'code-status-improveme' => 'fixme',
 101+ 'code-status-desc-improveme' => 'A reviewer marked this revision having some minor issues. It should be corrected.',
100102 'code-status-reverted' => 'reverted',
101103 'code-status-desc-reverted' => 'Revision was undone by a later revision.',
102104 'code-status-resolved' => 'resolved',
Index: trunk/extensions/CodeReview/modules/ext.codereview.css
@@ -69,6 +69,11 @@
7070 color: #ff0 !important;
7171 }
7272
 73+.mw-codereview-status-improveme:hover a,
 74+.mw-codereview-status-improveme:hover td a {
 75+ background: #ff9900 !important;
 76+}
 77+
7378 .mw-codereview-status-resolved,
7479 .mw-codereview-status-resolved td {
7580 background: #c0ffc0 !important;

Follow-up revisions

RevisionCommit summaryAuthorDate
r84854improveme for r84852reedy16:26, 27 March 2011
r84862Improve css for r84852, add non hover colourreedy17:22, 27 March 2011
r84863And even more CSS...reedy17:41, 27 March 2011
r84865f90 was way too dark, use fc0demon17:54, 27 March 2011
r85806Reverting r84852, r84854, r84862, r84863, r84865 until we get some better con...reedy17:31, 11 April 2011

Comments

#Comment by 😂 (talk | contribs)   16:25, 27 March 2011

+ 'code-status-improveme' => 'fixme',

You mean improveme :p

#Comment by Happy-melon (talk | contribs)   16:54, 27 March 2011

Needs CSS for the non-hover case, presumably?

#Comment by 😂 (talk | contribs)   17:17, 11 April 2011

There's some debate whether this should be a status in the workflow, or just a tag. Best to revert this & followups for now so we can go ahead and deploy.

Status & tagging log