r85806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85805‎ | r85806 | r85807 >
Date:17:31, 11 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Reverting r84852, r84854, r84862, r84863, r84865 until we get some better concensus on how to do this (and also to make deployment easier)
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/codereview.sql (modified) (history)
  • /trunk/extensions/CodeReview/modules/ext.codereview.css (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -236,7 +236,7 @@
237237 * @return Array
238238 */
239239 public static function getPossibleStates() {
240 - return array( 'new', 'fixme', 'improveme', 'reverted', 'resolved', 'ok', 'deferred', 'old' );
 240+ return array( 'new', 'fixme', 'reverted', 'resolved', 'ok', 'deferred', 'old' );
241241 }
242242
243243 /**
Index: trunk/extensions/CodeReview/codereview.sql
@@ -48,7 +48,6 @@
4949 -- Status key for how this thang is...
5050 -- 'new': Hasn't yet been reviewed
5151 -- 'fixme': This revision has some problem which needs to be resolved
52 - -- 'improveme': This revision has no major errors, but needs further work
5352 -- 'reverted': Was completely reverted by a later revision
5453 -- 'resolved': Issues with this rev have been since resolved
5554 -- 'ok': Reviewed, no issues spotted
Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -96,8 +96,6 @@
9797 'code-status-desc-new' => 'Revision is pending an action (default status).',
9898 'code-status-fixme' => 'fixme',
9999 'code-status-desc-fixme' => 'A reviewer marked this revision introduce a bug or is broken. It should be corrected.',
100 - 'code-status-improveme' => 'improveme',
101 - 'code-status-desc-improveme' => 'A reviewer marked this revision having some minor issues. It should be corrected.',
102100 'code-status-reverted' => 'reverted',
103101 'code-status-desc-reverted' => 'Revision was undone by a later revision.',
104102 'code-status-resolved' => 'resolved',
Index: trunk/extensions/CodeReview/modules/ext.codereview.css
@@ -69,21 +69,6 @@
7070 color: #ff0 !important;
7171 }
7272
73 -.mw-codereview-status-improveme,
74 -.mw-codereview-status-improveme td {
75 - background: #fc0 !important;
76 - color: white;
77 -}
78 -.mw-codereview-status-improveme:hover,
79 -.mw-codereview-status-improveme:hover td {
80 - background: #ff3300 !important;
81 - color: white;
82 -}
83 -.mw-codereview-status-improveme:hover a,
84 -.mw-codereview-status-improveme:hover td a {
85 - color: #ff0 !important;
86 -}
87 -
8873 .mw-codereview-status-resolved,
8974 .mw-codereview-status-resolved td {
9075 background: #c0ffc0 !important;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84852Add "improveme" for bug 28274reedy16:19, 27 March 2011
r84854improveme for r84852reedy16:26, 27 March 2011
r84862Improve css for r84852, add non hover colourreedy17:22, 27 March 2011
r84863And even more CSS...reedy17:41, 27 March 2011
r84865f90 was way too dark, use fc0demon17:54, 27 March 2011

Status & tagging log