r84688 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84687‎ | r84688 | r84689 >
Date:17:20, 24 March 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Follow-up r84686: removed now useless functions
Modified paths:
  • /trunk/extensions/DPLforum/DPLforum.php (modified) (history)
  • /trunk/extensions/DiscussionThreading/DiscussionThreading.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_GlobalFunctions.php (modified) (history)
  • /trunk/extensions/QPoll/qp_user.php (modified) (history)
  • /trunk/extensions/SubPageList/SubPageList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DiscussionThreading/DiscussionThreading.php
@@ -14,7 +14,6 @@
1515
1616 # Internationalisation file
1717 $wgExtensionMessagesFiles['DiscussionThreading'] = dirname( __FILE__ ) . '/DiscussionThreading.i18n.php';
18 -$wgExtensionFunctions[] = 'efDiscussionThreadSetup';
1918 $wgExtensionCredits['other'][] = array(
2019 'path' => __FILE__,
2120 'name' => 'DiscussionThreading',
@@ -40,13 +39,6 @@
4140 $wgHooks['DoEditSectionLink'][] = 'efDoDiscussionLink';
4241
4342 /**
44 - * Initial setup, add .i18n. messages from $IP/extensions/DiscussionThreading/DiscussionThreading.i18n.php
45 -*/
46 -function efDiscussionThreadSetup() {
47 -
48 -}
49 -
50 -/**
5143 * This function creates a linkobject for the editSectionLinkForOther function in linker
5244 *
5345 * @param $callobj Article object.
Index: trunk/extensions/SubPageList/SubPageList.php
@@ -69,20 +69,4 @@
7070 $wgHooks['ArticleDeleteComplete'][] = 'SPLHooks::onArticleDeleteComplete';
7171 $wgHooks['TitleMoveComplete'][] = 'SPLHooks::onTitleMoveComplete';
7272
73 -$wgExtensionFunctions[] = 'efSPLSetup';
74 -
75 -/**
76 - * Initialization function.
77 - *
78 - * @since 0.1
79 - */
80 -function efSPLSetup() {
81 - global $wgVersion;
82 -
83 - // This function has been deprecated in 1.16, but needed for earlier versions.
84 - if ( version_compare( $wgVersion, '1.16', '<' ) ) {
85 -
86 - }
87 -}
88 -
8973 require_once 'SubPageList.settings.php';
Index: trunk/extensions/QPoll/qp_user.php
@@ -171,18 +171,6 @@
172172 $wgHooks['LoadAllMessages'][] = new qp_Setup;
173173 }
174174
175 - static function onLoadAllMessages() {
176 - if ( !self::$messagesLoaded ) {
177 - global $wgVersion;
178 - self::$messagesLoaded = true;
179 - # for MW 1.15 (still being used by many customers)
180 - if ( version_compare( $wgVersion, '1.16', '<' ) ) {
181 -
182 - }
183 - }
184 - return true;
185 - }
186 -
187175 static function ParserFunctionsWords( $lang ) {
188176 $words = array();
189177 $words[ 'en' ] = array( 'qpuserchoice'=>array( 0, 'qpuserchoice' ) );
@@ -355,8 +343,6 @@
356344 $this->ppframe = $frame;
357345 $this->mRequest = &$wgRequest;
358346 $this->mResponse = $wgRequest->response();
359 - # Determine which messages will be used, according to the language.
360 - qp_Setup::onLoadAllMessages();
361347 # load current skin
362348 if ( self::$skin === null ) {
363349 self::$skin = $wgUser->getSkin();
@@ -1265,7 +1251,6 @@
12661252 var $error_message = 'no_such_poll';
12671253
12681254 function qpuserchoice( &$parser, $frame, $args ) {
1269 - qp_Setup::onLoadAllMessages();
12701255 $this->frame = &$frame;
12711256 $this->args = &$args;
12721257 if ( isset( $args[ 0 ] ) ) {
Index: trunk/extensions/DPLforum/DPLforum.php
@@ -35,7 +35,6 @@
3636 die( 1 );
3737 }
3838
39 -$wgExtensionFunctions[] = 'wfDPLforum';
4039 $wgHooks['ParserFirstCallInit'][] = 'wfDPLinit';
4140 $wgHooks['LanguageGetMagic'][] = 'wfDPLmagic';
4241 $wgExtensionCredits['parserhook'][] = array(
@@ -51,10 +50,6 @@
5251 $wgExtensionMessagesFiles['DPLforum'] = $dir . 'DPLforum.i18n.php';
5352 $wgAutoloadClasses['DPLForum'] = $dir . 'DPLforum_body.php';
5453
55 -function wfDPLforum() {
56 - // for compatibility with MW < 1.16
57 -}
58 -
5954 function wfDPLinit( &$parser ) {
6055 $parser->setHook( 'forum', 'parseForum' );
6156 $parser->setFunctionHook( 'forumlink', array( new DPLForum(), 'link' ) );
Index: trunk/extensions/MetavidWiki/includes/MV_GlobalFunctions.php
@@ -60,7 +60,6 @@
6161 $wgAPIModules;
6262
6363
64 - mvfInitMessages();
6564 //add the ALL page header
6665 mvfAutoAllPageHeader();
6766
@@ -420,15 +419,6 @@
421420 $mvgLang = new $mvLangClass();
422421 }
423422 }
424 -/**
425 - * Initialize messages - these settings must be applied later on, since
426 - * the MessageCache does not exist yet when the settings are loaded in
427 - * LocalSettings.php.
428 - * Function based on version in ContributionScores extension
429 - */
430 -function mvfInitMessages() {
431 -
432 -}
433423
434424 /*
435425 * Utility functions:

Follow-up revisions

RevisionCommit summaryAuthorDate
r84689Follow-up r84688: forgot to remove hook along with the functionialex17:25, 24 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84686Remove wfLoadExtensionMessages() in all trunk extensions (do not backport)...demon17:04, 24 March 2011

Comments

#Comment by 😂 (talk | contribs)   17:21, 24 March 2011

I thought I nailed these too. Thanks :)

Status & tagging log