r84686 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r84685‎ \| r84686 \| r84687 >
Date:	17:04, 24 March 2011
Author:	demon
Status:	deferred (Comments)
Tags:
Comment:	Remove wfLoadExtensionMessages() in all trunk extensions (do not backport) * This function has been a no-op since 1.16 * As of 1.18, this throws warnings to all callers * It will be removed entirely in 1.20 according to documentation * I skipped Semantic* on purpose This means: extensions IN TRUNK now require AT LEAST MediaWiki 1.16 or above.
Modified paths:	/trunk/extensions/ABC/ABC.php (modified) (history) /trunk/extensions/AbsenteeLandlord/AbsenteeLandlord.php (modified) (history) /trunk/extensions/AdminLinks/AdminLinks_body.php (modified) (history) /trunk/extensions/AdvancedRandom/AdvancedRandom_body.php (modified) (history) /trunk/extensions/AdvancedSearch/AdvancedSearch.body.php (modified) (history) /trunk/extensions/AmazonPlus/AmazonPlus.php (modified) (history) /trunk/extensions/ApprovedRevs/ApprovedRevs.hooks.php (modified) (history) /trunk/extensions/ApprovedRevs/ApprovedRevs_body.php (modified) (history) /trunk/extensions/ApprovedRevs/SpecialApprovedRevs.php (modified) (history) /trunk/extensions/ArticleToCategory2/ArticleToCategory2.php (modified) (history) /trunk/extensions/Asksql/Asksql_body.php (modified) (history) /trunk/extensions/BackAndForth/BackAndForth.class.php (modified) (history) /trunk/extensions/BadImage/BadImage.page.php (modified) (history) /trunk/extensions/Blahtex/Blahtex.php (modified) (history) /trunk/extensions/BlockTitles/BlockTitles.php (modified) (history) /trunk/extensions/Call/Call_body.php (modified) (history) /trunk/extensions/CategoryBrowser/CategoryBrowserCtrl.php (modified) (history) /trunk/extensions/CategoryBrowser/CategoryBrowserPage.php (modified) (history) /trunk/extensions/CategoryIntersection/CategoryIntersection_body.php (modified) (history) /trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php (modified) (history) /trunk/extensions/CategoryMultisortChinese/CategoryMultisortChinese.php (modified) (history) /trunk/extensions/CategoryOnUpload/CategoryOnUpload.php (modified) (history) /trunk/extensions/CategoryWatch/CategoryWatch.php (modified) (history) /trunk/extensions/ChangeAuthor/ChangeAuthor.body.php (modified) (history) /trunk/extensions/Checkpoint/Checkpoint.php (modified) (history) /trunk/extensions/Chemistry/ChemFunctions.php (modified) (history) /trunk/extensions/Chemistry/SpecialChemicalsources_body.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.list.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.page.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.php (modified) (history) /trunk/extensions/CommentPages/CommentPages.php (modified) (history) /trunk/extensions/CommentSpammer/CommentSpammer.php (modified) (history) /trunk/extensions/Commentbox/SpecialAddComment_body.php (modified) (history) /trunk/extensions/CommunityVoice/CommunityVoice.php (modified) (history) /trunk/extensions/Configure/Configure.func.php (modified) (history) /trunk/extensions/ConfigureWMF/ConfigureWMF.page.php (modified) (history) /trunk/extensions/Contributionseditcount/Contributionseditcount.php (modified) (history) /trunk/extensions/CooperationStatistics/CooperationStatistics_body.php (modified) (history) /trunk/extensions/CountEdits/CountEdits.page.php (modified) (history) /trunk/extensions/CreateBox/CreateBox.php (modified) (history) /trunk/extensions/Crosswiki/Block/CrosswikiBlock.page.php (modified) (history) /trunk/extensions/DPLforum/DPLforum.php (modified) (history) /trunk/extensions/DSMW/DSMW.php (modified) (history) /trunk/extensions/DataCenter/DataCenter.page.php (modified) (history) /trunk/extensions/DataTransfer/specials/DT_ImportCSV.php (modified) (history) /trunk/extensions/DataTransfer/specials/DT_ImportXML.php (modified) (history) /trunk/extensions/DataTransfer/specials/DT_ViewXML.php (modified) (history) /trunk/extensions/DeleteQueue/DeleteQueue.hooks.php (modified) (history) /trunk/extensions/DeleteQueue/SpecialDeleteQueue.php (modified) (history) /trunk/extensions/DeleteQueue/Views/DeleteQueueViewList.php (modified) (history) /trunk/extensions/DiscussionThreading/DiscussionThreading.php (modified) (history) /trunk/extensions/Drafts/Drafts.classes.php (modified) (history) /trunk/extensions/Drafts/Drafts.hooks.php (modified) (history) /trunk/extensions/Drafts/Drafts.pages.php (modified) (history) /trunk/extensions/Duplicator/Duplicator.page.php (modified) (history) /trunk/extensions/Duplicator/Duplicator.php (modified) (history) /trunk/extensions/EditConflict/CurrentEdits.php (modified) (history) /trunk/extensions/EditConflict/EditConflict.php (modified) (history) /trunk/extensions/EditMessages/EditMessages_body.php (modified) (history) /trunk/extensions/EditSimilar/EditSimilar.php (modified) (history) /trunk/extensions/EditUser/EditUser_body.php (modified) (history) /trunk/extensions/Editcount/Editcount_body.php (modified) (history) /trunk/extensions/EmailPage/EmailPage_body.php (modified) (history) /trunk/extensions/EmbedVideo/EmbedVideo.hooks.php (modified) (history) /trunk/extensions/EmergencyDeSysop/EmergencyDeSysop.php (modified) (history) /trunk/extensions/EmergencyDeSysop/SpecialEmergencyDeSysop.php (modified) (history) /trunk/extensions/Eval/Eval.class.php (modified) (history) /trunk/extensions/ExternalData/ED_GetData.php (modified) (history) /trunk/extensions/ExternalPages/ExternalPages_body.php (modified) (history) /trunk/extensions/FCKeditor/FCKeditor.body.php (modified) (history) /trunk/extensions/Farmer/SpecialFarmer.php (modified) (history) /trunk/extensions/FindSpam/FindSpam_body.php (modified) (history) /trunk/extensions/FlagPage/FlagPage.body.php (modified) (history) /trunk/extensions/FlagPage/FlagPage.hooks.php (modified) (history) /trunk/extensions/FlvHandler/FlvImageHandler.php (modified) (history) /trunk/extensions/ForcePreview/ForcePreview.php (modified) (history) /trunk/extensions/Form/Form.body.php (modified) (history) /trunk/extensions/FormatEmail/FormatEmail.php (modified) (history) /trunk/extensions/FramedVideo/FramedVideo.php (modified) (history) /trunk/extensions/FrontBackMatterForcedWikilinks/FrontBackMatterForcedWikilinks.php (modified) (history) /trunk/extensions/FundraiserPortal/DonateButton.php (modified) (history) /trunk/extensions/GlobalUserrights/GlobalUserrights_body.php (modified) (history) /trunk/extensions/HoneypotIntegration/HoneypotIntegration.class.php (modified) (history) /trunk/extensions/IMStatus/IMStatus.php (modified) (history) /trunk/extensions/ImportUsers/ImportUsers_body.php (modified) (history) /trunk/extensions/IndexFunction/IndexFunction_body.php (modified) (history) /trunk/extensions/IndexFunction/SpecialIndex.php (modified) (history) /trunk/extensions/InspectCache/InspectCache_body.php (modified) (history) /trunk/extensions/InterwikiIntegration/SpecialInterwikiIntegration.php (modified) (history) /trunk/extensions/InterwikiIntegration/SpecialInterwikiWatchlist.php (modified) (history) /trunk/extensions/InterwikiList/InterwikiList_body.php (modified) (history) /trunk/extensions/JSBreadCrumbs/JSBreadCrumbs.hooks.php (modified) (history) /trunk/extensions/JSKit/JSKit.php (modified) (history) /trunk/extensions/LastUserLogin/LastUserLogin_body.php (modified) (history) /trunk/extensions/LinkOpenID/LinkOpenID.php (modified) (history) /trunk/extensions/LogEntry/LogEntry.hooks.php (modified) (history) /trunk/extensions/LogEntry/LogEntry.page.php (modified) (history) /trunk/extensions/LookupUser/LookupUser.body.php (modified) (history) /trunk/extensions/LookupUser/LookupUser.php (modified) (history) /trunk/extensions/Lua/Lua.wrapper.php (modified) (history) /trunk/extensions/MassBlank/MassBlank_body.php (modified) (history) /trunk/extensions/MassEditRegex/MassEditRegex.class.php (modified) (history) /trunk/extensions/MathStatFunctions/MathStatFunctions.php (modified) (history) /trunk/extensions/MediaFunctions/MediaFunctions.class.php (modified) (history) /trunk/extensions/MetaKeywords/MetaKeywords.php (modified) (history) /trunk/extensions/MetavidWiki/includes/MV_GlobalFunctions.php (modified) (history) /trunk/extensions/MicroID/MicroID.php (modified) (history) /trunk/extensions/MiniDonation/MiniDonation.php (modified) (history) /trunk/extensions/MiniPreview/MiniPreview.php (modified) (history) /trunk/extensions/MinimumNameLength/MinimumNameLength.php (modified) (history) /trunk/extensions/MostRevisors/MostRevisors_body.php (modified) (history) /trunk/extensions/MultiBoilerplate/MultiBoilerplate.php (modified) (history) /trunk/extensions/MultiBoilerplate/SpecialBoilerplates_body.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/api/ApiFeedLQTThreads.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/DeletionController.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/Hooks.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/NewMessagesController.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/Threads.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/View.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/IndividualThreadHistoryView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/NewUserMessagesView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SpecialHotTopics.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SpecialMergeThread.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SpecialMoveThread.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SpecialSplitThread.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SummaryPageView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/TalkpageHeaderView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/TalkpageHistoryView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/TalkpageView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/ThreadActionPage.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/ThreadHistoricalRevisionView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/ThreadHistoryListingView.php (modified) (history) /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/ThreadPermalinkView.php (modified) (history) /trunk/extensions/NSFileRepo/NSFileRepo.php (modified) (history) /trunk/extensions/NetworkAuth/NetworkAuth.php (modified) (history) /trunk/extensions/NewUserNotif/NewUserNotif.class.php (modified) (history) /trunk/extensions/NewestPages/NewestPages.page.php (modified) (history) /trunk/extensions/NewsChannel/NewsChannel_body.php (modified) (history) /trunk/extensions/NssMySQLAuth/NssMySQLAuthPlugin.php (modified) (history) /trunk/extensions/OpenID/OpenID.hooks.php (modified) (history) /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history) /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history) /trunk/extensions/OpenID/SpecialOpenIDServer.body.php (modified) (history) /trunk/extensions/OpenID/SpecialOpenIDXRDS.body.php (modified) (history) /trunk/extensions/OtherSites/OtherSites.php (modified) (history) /trunk/extensions/PackageForce/PackageForce.php (modified) (history) /trunk/extensions/PageBy/PageByRenderer.php (modified) (history) /trunk/extensions/PagedTiffHandler/PagedTiffHandler_body.php (modified) (history) /trunk/extensions/PasswordReset/PasswordReset_body.php (modified) (history) /trunk/extensions/Patroller/Patroller.class.php (modified) (history) /trunk/extensions/Piwik/Piwik_specialpage.php (modified) (history) /trunk/extensions/Player/PlayerClass.php (modified) (history) /trunk/extensions/Player/SpecialPlayer.php (modified) (history) /trunk/extensions/PlayerStatsGrabber/PlayerStatsGrabber_body.php (modified) (history) /trunk/extensions/Plotters/Plotters.php (modified) (history) /trunk/extensions/Plotters/PlottersClass.php (modified) (history) /trunk/extensions/Plotters/SpecialPlotters.php (modified) (history) /trunk/extensions/Poll/Poll_body.php (modified) (history) /trunk/extensions/PovWatch/PovWatch_body.php (modified) (history) /trunk/extensions/ProfileMonitor/ProfileMonitor.class.php (modified) (history) /trunk/extensions/ProtectSection/ProtectSection_body.php (modified) (history) /trunk/extensions/PureWikiDeletion/PureWikiDeletion.hooks.php (modified) (history) /trunk/extensions/PureWikiDeletion/PureWikiDeletion.php (modified) (history) /trunk/extensions/PureWikiDeletion/SpecialPureWikiDeletion.php (modified) (history) /trunk/extensions/PurgeCache/PurgeCache_body.php (modified) (history) /trunk/extensions/QPoll/qp_results.php (modified) (history) /trunk/extensions/QPoll/qp_user.php (modified) (history) /trunk/extensions/RDFIO/specials/SpecialARC2Admin_body.php (modified) (history) /trunk/extensions/RDFIO/specials/SpecialRDFImport_body.php (modified) (history) /trunk/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php (modified) (history) /trunk/extensions/RPED/RPED.hooks.php (modified) (history) /trunk/extensions/RT/RT_body.php (modified) (history) /trunk/extensions/RandomUsersWithAvatars/RandomUsersWithAvatars.php (modified) (history) /trunk/extensions/Randomrootpage/Randomrootpage_body.php (modified) (history) /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history) /trunk/extensions/Redirect/Redirect.class.php (modified) (history) /trunk/extensions/RefHelper/RefHelper.create.php (modified) (history) /trunk/extensions/RefHelper/RefHelper.hooks.php (modified) (history) /trunk/extensions/RefHelper/RefHelper.search.php (modified) (history) /trunk/extensions/RefreshSpecial/RefreshSpecial.body.php (modified) (history) /trunk/extensions/ReplaceSet/ReplaceSet.class.php (modified) (history) /trunk/extensions/ReplaceText/SpecialReplaceText.php (modified) (history) /trunk/extensions/RightFunctions/RightFunctions.php (modified) (history) /trunk/extensions/SearchBox/SearchBox.hooks.php (modified) (history) /trunk/extensions/SecurePasswords/SecurePasswords.php (modified) (history) /trunk/extensions/SelectCategory/SelectCategoryFunctions.php (modified) (history) /trunk/extensions/SendmailToWiki/SendmailToWiki_body.php (modified) (history) /trunk/extensions/SharedUserRights/SharedUserRights_body.php (modified) (history) /trunk/extensions/SignDocument/SignDocument.php (modified) (history) /trunk/extensions/SignDocument/SpecialCreateSignDocument.php (modified) (history) /trunk/extensions/SignDocument/SpecialSignDocument.php (modified) (history) /trunk/extensions/SimpleSecurity/SimpleSecurity_body.php (modified) (history) /trunk/extensions/SimpleSurvey/SpecialSimpleSurvey.php (modified) (history) /trunk/extensions/SmoothGallery/SmoothGalleryClass.php (modified) (history) /trunk/extensions/SocialProfile/UserBoard/SpecialSendBoardBlast.php (modified) (history) /trunk/extensions/SpamDiffTool/SpamDiffTool_body.php (modified) (history) /trunk/extensions/SpamRegex/SpamRegexCore.php (modified) (history) /trunk/extensions/SpamRegex/SpecialSpamRegex.php (modified) (history) /trunk/extensions/SphinxSearch/SphinxSearch_body.php (modified) (history) /trunk/extensions/StalkerLog/StalkerLog.php (modified) (history) /trunk/extensions/StockCharts/StockCharts_body.php (modified) (history) /trunk/extensions/Storyboard/Storyboard.php (modified) (history) /trunk/extensions/SubPageList/SubPageList.php (modified) (history) /trunk/extensions/SubPageList3/SubPageList3.php (modified) (history) /trunk/extensions/Sudo/SpecialSudo.php (modified) (history) /trunk/extensions/TSPoll/TSPoll.php (modified) (history) /trunk/extensions/TagContent/TagContent.php (modified) (history) /trunk/extensions/TemplateLink/TemplateLink.body.php (modified) (history) /trunk/extensions/TimedMediaHandler/TimedMediaHandler_body.php (modified) (history) /trunk/extensions/TimedMediaHandler/TimedMediaTransformOutput.php (modified) (history) /trunk/extensions/TodoTasks/TodoTasks.php (modified) (history) /trunk/extensions/TodoTasks/TodoTasks_body.php (modified) (history) /trunk/extensions/UKGeocodingForMaps/UKGeocodingForMaps.php (modified) (history) /trunk/extensions/UnicodeConverter/UnicodeConverter_body.php (modified) (history) /trunk/extensions/UsageStatistics/UsageStatistics_body.php (modified) (history) /trunk/extensions/UserContactLinks/UserContactLinks.php (modified) (history) /trunk/extensions/UserImages/UserImages.class.php (modified) (history) /trunk/extensions/Validator/Validator.php (modified) (history) /trunk/extensions/Vote/Vote.page.php (modified) (history) /trunk/extensions/WatchSubpages/WatchSubpages_body.php (modified) (history) /trunk/extensions/WebStore/WebStoreClient.php (modified) (history) /trunk/extensions/WebStore/WebStoreCommon.php (modified) (history) /trunk/extensions/WhatIsMyIP/WhatIsMyIP_body.php (modified) (history) /trunk/extensions/WhiteListEdit/WhiteListAuth.php (modified) (history) /trunk/extensions/WhiteListEdit/WhiteListEdit_body.php (modified) (history) /trunk/extensions/WhoIsWatching/WhoIsWatching_body.php (modified) (history) /trunk/extensions/WhosOnline/WhosOnlineSpecialPage.php (modified) (history) /trunk/extensions/Widgets/WidgetRenderer.php (modified) (history) /trunk/extensions/WikiArticleFeeds/WikiArticleFeeds.php (modified) (history) /trunk/extensions/WikiSync/WikiSync.php (modified) (history) /trunk/extensions/WikiTrust/includes/RemoteMode.php (modified) (history) /trunk/extensions/WikiTrust/includes/WikiTrustBase.php (modified) (history) /trunk/extensions/WikimediaIncubator/IncubatorTest.php (modified) (history) /trunk/extensions/WikimediaIncubator/SpecialViewUserLang.php (modified) (history) /trunk/extensions/WikimediaIncubator/TestWikiRC.php (modified) (history) /trunk/extensions/YouTubeAuthSub/YouTubeAuthSub_body.php (modified) (history) /trunk/extensions/regexBlock/SpecialRegexBlock.php (modified) (history) /trunk/extensions/regexBlock/regexBlockCore.php (modified) (history) /trunk/extensions/timeline/Timeline.php (modified) (history) /trunk/extensions/uniwiki/Authors/Authors.php (modified) (history) /trunk/extensions/uniwiki/AutoCreateCategoryPages/AutoCreateCategoryPages.body.php (modified) (history) /trunk/extensions/uniwiki/CatBoxAtTop/CatBoxAtTop.php (modified) (history) /trunk/extensions/uniwiki/CreatePage/CreatePage_body.php (modified) (history) /trunk/extensions/uniwiki/FormatChanges/FormatChanges.body.php (modified) (history) /trunk/extensions/uniwiki/GenericEditPage/GenericEditPage.php (modified) (history) /trunk/extensions/uniwiki/Layouts/Layouts.php (modified) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r84688	Follow-up r84686: removed now useless functions	ialex	17:20, 24 March 2011
r84690	Partial revert r84686: Yaron wants to maintain b/c in these still	demon	17:38, 24 March 2011

Comments

#Comment by Reedy (talk | contribs) 17:13, 24 March 2011

Wheeeeeee

#Comment by Nikerabbit (talk | contribs) 08:44, 22 June 2011

Could you port the SimpleSecurity fix for 1.17 branch? Bug 29525.

Status & tagging log

22:59, 15 April 2011 Reedy (talk | contribs) changed the status of r84686 [removed: new added: deferred]