r84650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r84649‎ | r84650 | r84651 >
Date:00:35, 24 March 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Delete daft WebStoreStart.php file
Modified paths:
  • /trunk/extensions/WebStore/WebStoreStart.php (deleted) (history)

Diff [purge]

Index: trunk/extensions/WebStore/WebStoreStart.php
——@@ -1,25 +0,0 @@
2 -<?php
3 -
4 -/**
5 - * WebStore startup file
6 - */
7 -
8 -
9 -$IP = dirname( __FILE__ ) . '/../..';
10 -chdir( $IP );
11 -require( './includes/WebStart.php' );
12 -
13 -if ( !defined( 'MW_WEBSTORE_ENABLED' ) ) {
14 - echo <<<EOT
15 -<html><body>
16 -<p>The WebStore extension is disabled. Enable WebStore by putting:</p>
17 -
18 -<pre>require( "\$IP/extensions/WebStore.php" );</pre>
19 -
20 -<p>in your LocalSettings.php</p>
21 -</body></html>
22 -EOT;
23 - exit( 1 );
24 -}
25 -
26 -

Follow-up revisions

RevisionCommit summaryAuthorDate
r99324Revert r84650...reedy20:50, 8 October 2011

Comments

#Comment by Tbleher (talk | contribs)   19:23, 8 October 2011

This commit breaks the WebStore extension for me, because the WebStoreStart.php file is still referenced by a bunch of other files in the extension (e.g. delete.php, publish.php).

I assume there was some reason you deleted the file, so my question is: How is the extension to be used? Is it used currently on Wikipedia? If yes, what alternative WebStoreStart.php file is used there? If no, I propose to restore the file to its old state, so the extension works again :)

Status & tagging log