r84651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84650‎ | r84651 | r84652 >
Date:00:37, 24 March 2011
Author:laner
Status:deferred
Tags:
Comment:
Made Special:NovaKey's display more consistent with the rest of the interface.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackManager.i18n.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaKey.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaKey.php
@@ -194,14 +194,18 @@
195195 $out .= $sk->link( $this->getTitle(), wfMsgHtml( 'openstackmanager-importkey' ), array(), array( 'action' => 'import' ) );
196196 $keypairs = $this->userLDAP->getKeypairs();
197197 $keysOut = '';
 198+ $keysOut .= Html::element( 'th', array(), wfMsg( 'openstackmanager-keys' ) );
 199+ $keysOut .= Html::element( 'th', array(), wfMsg( 'openstackmanager-actions' ) );
198200 foreach ( $keypairs as $hash => $key ) {
199201 $keyOut = Html::element( 'td', array(), $key );
200202 $msg = wfMsgHtml( 'openstackmanager-delete' );
201203 $link = $sk->link( $this->getTitle(), $msg, array(), array( 'action' => 'delete', 'hash' => $hash ) );
202 - $keyOut .= Html::rawElement( 'td', array(), $link );
 204+ $action = Html::rawElement( 'li', array(), $link );
 205+ $action = Html::rawElement( 'ul', array(), $action );
 206+ $keyOut .= Html::rawElement( 'td', array(), $action );
203207 $keysOut .= Html::rawElement( 'tr', array(), $keyOut );
204208 }
205 - $out .= Html::rawElement( 'table', array(), $keysOut );
 209+ $out .= Html::rawElement( 'table', array( 'id' => 'novakeylist', 'class' => 'wikitable' ), $keysOut );
206210 } else {
207211 $wgOut->addWikiMsg( 'openstackmanager-invalidkeypair' );
208212 }
Index: trunk/extensions/OpenStackManager/OpenStackManager.i18n.php
@@ -154,6 +154,7 @@
155155 'openstackmanager-importkey' => 'Import a new key',
156156 'openstackmanager-name' => 'Name',
157157 'openstackmanager-fingerprint' => 'Fingerprint',
 158+ 'openstackmanager-keys' => 'Keys',
158159 'openstackmanager-invalidkeypair' => 'Invalid keypair location configured.',
159160 'openstackmanager-keypairimportfailed' => 'Failed to import keypair.',
160161 'openstackmanager-keypairimported' => 'Imported keypair.',

Status & tagging log