r84135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84134‎ | r84135 | r84136 >
Date:23:49, 16 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Fix r84131, Installer classes not initialised/in usage, so we can't do this.

Change for hardcoded 5.2.3 as current minimum version
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -27,10 +27,10 @@
2828 $maintClass = false;
2929
3030 // Make sure we're on PHP5 or better
31 -if ( version_compare( PHP_VERSION, Installer::MINIMUM_PHP_VERSION ) < 0 ) {
32 - die ( "Sorry! This version of MediaWiki requires PHP " . Installer::MINIMUM_PHP_VERSION . "; you are running " .
 31+if ( version_compare( PHP_VERSION, '5.2.3' ) < 0 ) {
 32+ die ( "Sorry! This version of MediaWiki requires PHP 5.2.3; you are running " .
3333 PHP_VERSION . ".\n\n" .
34 - "If you are sure you already have PHP " . Installer::MINIMUM_PHP_VERSION . " or higher installed, it may be\n" .
 34+ "If you are sure you already have PHP 5.2.3 or higher installed, it may be\n" .
3535 "installed in a different path from PHP " . PHP_VERSION . ". Check with your system\n" .
3636 "administrator.\n" );
3737 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84131Less hardcoding...reedy22:43, 16 March 2011

Comments

#Comment by Platonides (talk | contribs)   23:51, 16 March 2011

Changes 5.1.0 to 5.2.3 compared with r84130 (reverts r84131)

Status & tagging log