r84131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84130‎ | r84131 | r84132 >
Date:22:43, 16 March 2011
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Less hardcoding...
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -27,10 +27,10 @@
2828 $maintClass = false;
2929
3030 // Make sure we're on PHP5 or better
31 -if ( version_compare( PHP_VERSION, '5.1.0' ) < 0 ) {
32 - die ( "Sorry! This version of MediaWiki requires PHP 5.1.x; you are running " .
 31+if ( version_compare( PHP_VERSION, Installer::MINIMUM_PHP_VERSION ) < 0 ) {
 32+ die ( "Sorry! This version of MediaWiki requires PHP " . Installer::MINIMUM_PHP_VERSION . "; you are running " .
3333 PHP_VERSION . ".\n\n" .
34 - "If you are sure you already have PHP 5.1.x or higher installed, it may be\n" .
 34+ "If you are sure you already have PHP " . Installer::MINIMUM_PHP_VERSION . " or higher installed, it may be\n" .
3535 "installed in a different path from PHP " . PHP_VERSION . ". Check with your system\n" .
3636 "administrator.\n" );
3737 }

Sign-offs

UserFlagDate
Krinkleinspected22:55, 16 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r84135Fix r84131, Installer classes not initialised/in usage, so we can't do this....reedy23:49, 16 March 2011

Comments

#Comment by Platonides (talk | contribs)   23:46, 16 March 2011

Breaks running update.php

Fatal error: Class 'Installer' not found in maintenance/Maintenance.php on line 30

Status & tagging log