r83997 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83996‎ | r83997 | r83998 >
Date:04:37, 15 March 2011
Author:neilk
Status:ok
Tags:
Comment:
the vertical tab \v and form feed \f escapes are not available in php5.2.4 which is what we run in production. Using equivalent hexadecimal
Modified paths:
  • /trunk/phase3/includes/libs/JavaScriptMinifier.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/JavaScriptMinifier.php
@@ -422,7 +422,7 @@
423423 while( $pos < $length ) {
424424 // First, skip over any whitespace and multiline comments, recording whether we
425425 // found any newline character
426 - $skip = strspn( $s, " \t\n\r\v\f", $pos );
 426+ $skip = strspn( $s, " \t\n\r\xb\xc", $pos );
427427 if( !$skip ) {
428428 $ch = $s[$pos];
429429 if( $ch === '/' && substr( $s, $pos, 2 ) === '/*' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r846131.17wmf1: MFT r81692, r82468, r83814, r83885, r83891, r83897, r83902, r83903,...catrope17:42, 23 March 2011
r85434MFT: r83885, r83891, r83897, r83902, r83903, r83934, r83965, r83979, r83988, ...demon13:38, 5 April 2011

Status & tagging log