r83989 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83988‎ | r83989 | r83990 >
Date:02:03, 15 March 2011
Author:kaldari
Status:ok
Tags:
Comment:
oops, don't delete char before the slash, followup to r83902
Modified paths:
  • /trunk/phase3/includes/libs/CSSMin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/CSSMin.php
@@ -146,7 +146,7 @@
147147 $file = "{$local}/{$match['file'][0]}";
148148 // bug 27052 - Guard against double slashes, because foo//../bar
149149 // apparently resolves to foo/bar on (some?) clients
150 - $url = preg_replace( '#[^:]//+#', '/', $url );
 150+ $url = preg_replace( '#([^:])//+#', '\1/', $url );
151151 $replacement = false;
152152 if ( $local !== false && file_exists( $file ) ) {
153153 // Add version parameter as a time-stamp in ISO 8601 format,

Follow-up revisions

RevisionCommit summaryAuthorDate
r846131.17wmf1: MFT r81692, r82468, r83814, r83885, r83891, r83897, r83902, r83903,...catrope17:42, 23 March 2011
r85434MFT: r83885, r83891, r83897, r83902, r83903, r83934, r83965, r83979, r83988, ...demon13:38, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83902(bug 27052) CSSMin generated URLs like foo//../bar in some cases, which appar...catrope15:01, 14 March 2011

Status & tagging log