r83802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83801‎ | r83802 | r83803 >
Date:00:31, 13 March 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Tweak comment format

Fix space/brace

Define member variable
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -153,7 +153,8 @@
154154 }
155155 }
156156
157 -/* use TablePager for prettified output. We have to pretend that we're
 157+/**
 158+ * Use TablePager for prettified output. We have to pretend that we're
158159 * getting data from a table when in fact not all of it comes from the database.
159160 */
160161 class AllmessagesTablePager extends TablePager {
@@ -170,6 +171,11 @@
171172 */
172173 public $lang;
173174
 175+ /**
 176+ * @var null|bool
 177+ */
 178+ public $custom;
 179+
174180 function __construct( $page, $conds, $langObj = null ) {
175181 parent::__construct();
176182 $this->mIndexField = 'am_title';
@@ -251,8 +257,7 @@
252258 if( $this->foreign ) {
253259 $title = explode( '/', $s->page_title );
254260 if( count( $title ) === 2 && $this->langcode == $title[1]
255 - && isset( $xNames[$title[0]] ) )
256 - {
 261+ && isset( $xNames[$title[0]] ) ) {
257262 $pageFlags["{$title[0]}"] = true;
258263 }
259264 } elseif( isset( $xNames[$s->page_title] ) ) {
@@ -268,7 +273,8 @@
269274 return array( 'pages' => $pageFlags, 'talks' => $talkFlags );
270275 }
271276
272 - /* This function normally does a database query to get the results; we need
 277+ /**
 278+ * This function normally does a database query to get the results; we need
273279 * to make a pretend result using a FakeResultWrapper.
274280 */
275281 function reallyDoQuery( $offset, $limit, $descending ) {

Comments

#Comment by Hashar (talk | contribs)   20:28, 25 March 2011

What is that $custom for? Does it really need to be public?

#Comment by Reedy (talk | contribs)   20:45, 25 March 2011

The surround $lang and $mLimitsShown are.

Probably doesn't need to be, no

Status & tagging log