r83801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83800‎ | r83801 | r83802 >
Date:00:24, 13 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Bit of explicit parameter definition.

Spaces, braces
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -34,6 +34,8 @@
3535 */
3636 protected $table;
3737
 38+ protected $filter, $prefix, $langCode;
 39+
3840 /**
3941 * Constructor
4042 */
@@ -159,6 +161,11 @@
160162 public $mLimitsShown;
161163
162164 /**
 165+ * @var Skin
 166+ */
 167+ protected $mSkin;
 168+
 169+ /**
163170 * @var Language
164171 */
165172 public $lang;
@@ -276,7 +283,7 @@
277284 if( $customised !== $this->custom &&
278285 ( $descending && ( $key < $offset || !$offset ) || !$descending && $key > $offset ) &&
279286 ( ( $this->prefix && preg_match( $this->prefix, $key ) ) || $this->prefix === false )
280 - ){
 287+ ) {
281288 $actual = wfMessage( $key )->inLanguage( $this->langcode )->plain();
282289 $default = wfMessage( $key )->inLanguage( $this->langcode )->useDatabase( false )->plain();
283290 $result->result[] = array(
@@ -288,7 +295,9 @@
289296 );
290297 $count++;
291298 }
292 - if( $count == $limit ) break;
 299+ if( $count == $limit ) {
 300+ break;
 301+ }
293302 }
294303 return $result;
295304 }
@@ -394,15 +403,19 @@
395404 'am_default' => wfMsg( 'allmessagesdefault' )
396405 );
397406 }
 407+
398408 function getTitle() {
399409 return SpecialPage::getTitleFor( 'Allmessages', false );
400410 }
 411+
401412 function isFieldSortable( $x ){
402413 return false;
403414 }
 415+
404416 function getDefaultSort(){
405417 return '';
406418 }
 419+
407420 function getQueryInfo(){
408421 return '';
409422 }

Status & tagging log