r82823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82822‎ | r82823 | r82824 >
Date:00:35, 26 February 2011
Author:bawolff
Status:ok
Tags:
Comment:
revert 70005 - Causes bug where if a revision is imported on an already existing page, special:nuke
will delete the whole page, where it is expected to only delete the page if the user is only one to contribute.

Also breaks listing file uploads (reported by Manuelt15 on irc).
Modified paths:
  • /trunk/extensions/Nuke/Nuke_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Nuke/Nuke_body.php
——@@ -202,7 +202,7 @@
203203 'COUNT(*) AS edits'
204204 );
205205
206 - $where = array( "(rc_new = 1) OR (rc_log_type = 'import' AND rc_log_action = 'upload')" );
 206+ $where = array( "(rc_new = 1) OR (rc_log_type = 'upload' AND rc_log_action = 'upload')" );
207207
208208 if ( $username == '' ) {
209209 $what[] = 'rc_user_text';

Follow-up revisions

RevisionCommit summaryAuthorDate
r82824MFT r82823, reverting r70005reedy00:47, 26 February 2011
r82825MFT r82823, reverting r70005reedy00:47, 26 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70005*(bug 9120) Special:Nuke does not list imported page...reedy12:00, 27 July 2010

Status & tagging log