r70005 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70004‎ | r70005 | r70006 >
Date:12:00, 27 July 2010
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
*(bug 9120) Special:Nuke does not list imported page

Patch by Frank Ralf
Modified paths:
  • /trunk/extensions/Nuke/Nuke_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Nuke/Nuke_body.php
——@@ -122,7 +122,7 @@
123123 array( 'rc_namespace', 'rc_title', 'rc_timestamp', 'COUNT(*) AS edits' ),
124124 array(
125125 'rc_user_text' => $username,
126 - "(rc_new = 1) OR (rc_log_type = 'upload' AND rc_log_action = 'upload')"
 126+ '(rc_new = 1) OR (rc_log_type = "import" AND rc_log_action = "upload")'
127127 ),
128128 __METHOD__,
129129 array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r70229Fixup r70005 per CR (Hey, I only applied the patch ;))reedy19:25, 31 July 2010
r82823revert 70005 - Causes bug where if a revision is imported on an already exist...bawolff00:35, 26 February 2011
r82824MFT r82823, reverting r70005reedy00:47, 26 February 2011
r82825MFT r82823, reverting r70005reedy00:47, 26 February 2011

Comments

#Comment by Liangent (talk | contribs)   15:26, 31 July 2010

It seems that the standard is to use single quotes in SQL.

#Comment by Catrope (talk | contribs)   15:28, 31 July 2010

Double quotes signify field names, so I believe this'll break in some DBMSes at least.

#Comment by Duplicatebug (talk | contribs)   11:18, 26 February 2011

MediaWiki have Database::addQuotes() to solve this problem.

#Comment by Reedy (talk | contribs)   12:22, 26 February 2011

Yes, we know. And its got identifier quotes too.

And if you do it correctly it will take care of it all for you!

Status & tagging log