r82524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82523‎ | r82524 | r82525 >
Date:18:14, 20 February 2011
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Adapt Gadgets to changes in r81692
Modified paths:
  • /trunk/extensions/Gadgets/Gadgets_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Gadgets/Gadgets_body.php
@@ -314,11 +314,11 @@
315315 public function getModule() {
316316 $pages = array();
317317 foreach( $this->styles as $style ) {
318 - $pages[$style] = array( 'ns' => NS_MEDIAWIKI, 'type' => 'style' );
 318+ $pages['MediaWiki:' . $style] = array( 'type' => 'style' );
319319 }
320320 if ( $this->supportsResourceLoader() ) {
321321 foreach ( $this->scripts as $script ) {
322 - $pages[$script] = array( 'ns' => NS_MEDIAWIKI, 'type' => 'script' );
 322+ $pages['MediaWiki:' . $script] = array( 'type' => 'script' );
323323 }
324324 }
325325 if ( !count( $pages ) ) {
@@ -467,8 +467,8 @@
468468 * @param $pages Array: Associative array of pages in ResourceLoaderWikiModule-compatible
469469 * format, for example:
470470 * array(
471 - * 'Gadget-foo.js' => array( 'ns' => NS_MEDIAWIKI, 'type' => 'script' ),
472 - * 'Gadget-foo.css' => array( 'ns' => NS_MEDIAWIKI, 'type' => 'style' ),
 471+ * 'MediaWiki:Gadget-foo.js' => array( 'type' => 'script' ),
 472+ * 'MediaWiki:Gadget-foo.css' => array( 'type' => 'style' ),
473473 * )
474474 * @param $dependencies Array: Names of resources this module depends on
475475 */

Follow-up revisions

RevisionCommit summaryAuthorDate
r846831.17wmf1: MFT r82524 to unbreak Gadgetscatrope15:41, 24 March 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81692Fixes for ResourceLoaderWikiModule r72776. No serious bugs found, do not merg...tstarling06:34, 8 February 2011

Comments

#Comment by Bawolff (talk | contribs)   15:51, 24 March 2011

Accidentally edit conflicted on this. resetting to ok. Also removing the 1.17wmf1 tag since it got merged before I actually tagged it (Really wish code review had ec detection ;)

Status & tagging log