r82499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82498‎ | r82499 | r82500 >
Date:00:13, 20 February 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Save and restore $wgHooks in NewParserTest.
ParserGetVariableValueTs hook still being set to ParserTest::getFakeTimestamp was the reason for the crazy failures of MagicVariableTest inside phpunit that I was seeing.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php
——@@ -56,6 +56,7 @@
5757 );
5858
5959 $tmpGlobals['wgEnableParserCache'] = false;
 60+ $tmpGlobals['wgHooks'] = array();
6061 $tmpGlobals['wgDeferredUpdateList'] = array();
6162 $tmpGlobals['wgMemc'] = &wfGetMainCache();
6263 $tmpGlobals['messageMemc'] = &wfGetMessageCacheStorage();

Follow-up revisions

RevisionCommit summaryAuthorDate
r82867Finally commit the testing stuff I have been with this week. Could be conside...platonides21:49, 26 February 2011

Comments

#Comment by Hashar (talk | contribs)   12:10, 22 February 2011

Thanks ! :)

Status & tagging log