r82498 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82497‎ | r82498 | r82499 >
Date:00:12, 20 February 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.watch.ajax.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.watch.ajax.js
@@ -113,7 +113,11 @@
114114
115115 $link.data( 'action', otheraction );
116116 wgAjaxWatch.setLinkText( $link, otheraction );
117 - $link.attr( 'href', $link.attr( 'href' ).replace( '&action=' + action , '&action=' + otheraction ) );
 117+ $link.attr( 'href',
 118+ mw.config.get( 'wgScript' )
 119+ + '?title=' + mw.util.wikiUrlencode( mw.config.get( 'wgPageName' ) )
 120+ + '&action=' + otheraction
 121+ );
118122 if( $link.closest( 'li' ).attr( 'id' ) == 'ca-' + action ) {
119123 $link.closest( 'li' ).attr( 'id', 'ca-' + otheraction );
120124 // update the link text with the new message

Follow-up revisions

RevisionCommit summaryAuthorDate
r107354[mediawiki.action.watch.ajax.js] Rewrite using mw.Api and fixes bug 27146...krinkle01:21, 27 December 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:41, 20 December 2011

Did not fix the bug.

#Comment by Krinkle (talk | contribs)   02:31, 29 December 2011

Module has been rewritten in r107354. Should be okay now.

Status & tagging log