r82452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82451‎ | r82452 | r82453 >
Date:13:39, 19 February 2011
Author:ialex
Status:ok
Tags:
Comment:
* Use $this->mTitle instead of $wgTitle
* Put back the wfMsgForContentNoTrans() added in r66835 but reverted in r68707 since wfMsgForContent() is breaking the {{...}} syntax
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1357,7 +1357,7 @@
13581358 * @param $message String
13591359 */
13601360 function addToSidebar( &$bar, $message ) {
1361 - $this->addToSidebarPlain( $bar, wfMsgForContent( $message ) );
 1361+ $this->addToSidebarPlain( $bar, wfMsgForContentNoTrans( $message ) );
13621362 }
13631363
13641364 /**
@@ -1423,14 +1423,14 @@
14241424 'active' => false
14251425 );
14261426 } else if ( ( substr( $line, 0, 2 ) == '{{' ) && ( substr( $line, -2 ) == '}}' ) ) {
1427 - global $wgParser, $wgTitle;
 1427+ global $wgParser;
14281428
14291429 $line = substr( $line, 2, strlen( $line ) - 4 );
14301430
14311431 $options = new ParserOptions();
14321432 $options->setEditSection( false );
14331433 $options->setInterfaceMessage( true );
1434 - $wikiBar[$heading] = $wgParser->parse( wfMsgForContentNoTrans( $line ) , $wgTitle, $options )->getText();
 1434+ $wikiBar[$heading] = $wgParser->parse( wfMsgForContentNoTrans( $line ) , $this->mTitle, $options )->getText();
14351435 } else {
14361436 continue;
14371437 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r82472Follow-up r82452: need to transform entries sinces some wiki like to use vari...ialex19:15, 19 February 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66835Follow up r62958. addToSidebar() was added in r59215, we still can redesign i...platonides16:38, 24 May 2010
r68707Revert r66835, r66846: it's too late to break interfaces in 1.16.tstarling06:39, 29 June 2010

Status & tagging log