r66846 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66845‎ | r66846 | r66847 >
Date:20:01, 24 May 2010
Author:platonides
Status:reverted
Tags:
Comment:
Follow up r66835. Some people use direct urls in MediaWiki:Sidebar instead of -url messages (eg. {{FULLURL:Special:RecentChanges|translations=only&trailer=/{{UILANGCODE}}}}).
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -2136,6 +2136,9 @@
21372137 }
21382138 } else {
21392139 if( strpos( $line, '|' ) !== false ) { // sanity check
 2140+ global $wgMessageCache;
 2141+ $line = $wgMessageCache->transform( $line );
 2142+
21402143 $line = array_map( 'trim', explode( '|', trim( $line, '* ' ), 2 ) );
21412144 $link = wfMsgForContent( $line[0] );
21422145 if( $link == '-' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r66848MFT r66846platonides20:15, 24 May 2010
r68707Revert r66835, r66846: it's too late to break interfaces in 1.16.tstarling06:39, 29 June 2010
r68708Revert r66836, r66846 (equivalent to MFT r68707): it's too late to break inte...tstarling06:43, 29 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66835Follow up r62958. addToSidebar() was added in r59215, we still can redesign i...platonides16:38, 24 May 2010

Status & tagging log