r82395 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82394‎ | r82395 | r82396 >
Date:12:25, 18 February 2011
Author:ialex
Status:ok
Tags:
Comment:
* Use appendQueryValue() instead of appendQuery() so that if e.g. printable=no is already present in the URL, it doesn't become printable=no&printable=yes
* Call getLocalURL() on the local Title object instead of $wgTitle in WebRequest
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
——@@ -1157,7 +1157,7 @@
11581158 if ( !$out->isPrintable() ) {
11591159 $nav_urls['print'] = array(
11601160 'text' => wfMsg( 'printableversion' ),
1161 - 'href' => $wgRequest->appendQuery( 'printable=yes' )
 1161+ 'href' => $this->mTitle->getLocalURL( $wgRequest->appendQueryValue( 'printable', 'yes', true ) )
11621162 );
11631163 }
11641164

Follow-up revisions

RevisionCommit summaryAuthorDate
r82455* Use OutputPage::getSyndicationLinks() to build feed links...ialex14:40, 19 February 2011

Status & tagging log