r82394 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r82393‎ \| r82394 \| r82395 >
Date:	11:55, 18 February 2011
Author:	ialex
Status:	ok
Tags:
Comment:	We have already have a printable flag in the OutputPage object, so use it. This was causing to have the printable version for every non-empty version of the printable paramter, instead of only for "yes".
Modified paths:	/trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
—	—	@@ -2411,7 +2411,7 @@
2412	2412	'only' => $only,
2413	2413	);
2414	2414	// Propagate printable and handheld parameters if present
2415		~~- if ( $wgRequest->getBool( 'printable' ) ) {~~
	2415	+ if ( $this->isPrintable() ) {
2416	2416	$query['printable'] = 1;
2417	2417	}
2418	2418	if ( $wgRequest->getBool( 'handheld' ) ) {

11:58, 28 February 2011 Hashar (talk | contribs) changed the status of r82394 [removed: new added: ok]